NZOI / nztrain
33%
master: 38%

LAST BUILD BRANCH: feature/subtask-scoring
DEFAULT BRANCH: master
Repo Added
Files 140
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH add-javascript-into-master
branch: add-javascript-into-master
CHANGE BRANCH
x

747

push

travis-ci

tom93 
Revert "Change v8 build directory from /v8-build to /tmp/v8-build"

It's not as simple as I thought and needs discussion.

The problem with using /tmp/v8-build is that another user might have
already created that directory. If we want the script to be safe in
the presence of malicious users on the same machine, we need another
approach:

1. Use ~/v8-build. Simple and safe. Won't be cleaned up automatically
   on reboot (unlike /tmp). I think this is the best option.

2. Use /v8-build. This only works when running as root; it would be
   useful if the script could also work for normal users.

3. Use /tmp/v8-build, but exit if mkdir fails and ask the user has to
   manually delete /tmp/v8-build (might exist from earlier builds).
   This is simple, but requires manual intervention in the case of
   failed builds and doesn't allow to resume build from previous
   state.

4. Use /tmp/v8-build, if mkdir fails delete it and try again. Similar
   to (3.) but doesn't require manual intervention.

5. Use /tmp/v8-build, if mkdir fails check ownership (`stat -c %u`)
   and abort if it's not the current one. Complex, but allows resuming
   build from previous state.

6. Use `mktemp` to create a different temporary directory each time.
   Failed builds would use up lots of space. Slightly harder to
   inspect build directory manually (need to find the directory name
   in the output of script).

2317 of 6991 relevant lines covered (33.14%)

4.75 hits per line

Relevant lines Covered
6991 RELEVANT LINES 2317 COVERED LINES
4.75 HITS PER LINE
Source Files on add-javascript-into-master
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
747 add-javascript-into-master Revert "Change v8 build directory from /v8-build to /tmp/v8-build" It's not as simple as I thought and needs discussion. The problem with using /tmp/v8-build is that another user might have already created that directory. If we want the script t... push tom93 travis-ci pending completion  
673 add-javascript-into-master Rename v8 install script to "v8.bash" to match the other scripts push tom93 travis-ci pending completion  
672 add-javascript-into-master Add fixes for V8 install script push Holmes98 travis-ci pending completion  
667 add-javascript-into-master Enable "universe" component of security repository in sources.list from debootstrap script The "universe" component is enabled for the "$SUITE" repository, so it should also be enabled for "$SUITE-security" to get security updates. Discovered be... push Holmes98 travis-ci pending completion  
666 add-javascript-into-master Enable "universe" component of security repository in sources.list from debootstrap script The "universe" component is enabled for the "$SUITE" repository, so it should also be enabled for "$SUITE-security" to get security updates. Discovered be... push Holmes98 travis-ci pending completion  
660 add-javascript-into-master Build V8 inside chroot push Holmes98 travis-ci pending completion  
659 add-javascript-into-master Build V8 inside chroot push Holmes98 travis-ci pending completion  
645 add-javascript-into-master Fix ambiguous match in submissions spec push Holmes98 travis-ci pending completion  
644 add-javascript-into-master Only build V8 if not in Travis CI push Holmes98 travis-ci pending completion  
See All Builds (1144)