NZOI / nztrain
37%
master: 38%

LAST BUILD BRANCH: feature/subtask-scoring
DEFAULT BRANCH: master
Repo Added
Files 140
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-file-attachments
branch: fix-file-attachments
CHANGE BRANCH
x

coverage: 37.131%. Remained the same
7446176770

Pull #258

github

tom93 
Fix crash when adding file attachment to problem

Previously, if there was a validation error when adding a file
attachment to a problem (e.g. "Filepath has already been taken",
"Filepath extension doesn't match file"), then instead of displaying
the validation error message, there would be a 500 Internal Server
Error (First argument in form cannot contain nil or be empty). Full
trace below.

The cause was an incomplete renaming in commit 1e931189 (enable file
attachments for problems, with shared code for filelinks of groups and
problems, 2013-12-19). The code path that triggers when there is a
validation error still used some old variable names, causing the
crash.

Fix by updating those variable names.

Full error trace:

```
Completed 500 Internal Server Error in 764ms (ActiveRecord: 64.1ms)
First argument in form cannot contain nil or be empty excluded from capture: DSN not set

ActionView::Template::Error (First argument in form cannot contain nil or be empty):
    1: <%= form_for @new_filelink, :url => index_path do |f| %>
    2:   <% if @new_filelink.errors.any? %>
    3:     <div id="error_explanation">
    4:       <h2><%= pluralize(@new_filelink.errors.count, "error") %> prohibited this post from being saved:</h2>
  app/views/filelinks/roots/index.html.erb:1:in `_app_views_filelinks_roots_index_html_erb___4252713757973532291_70289880'
  app/controllers/filelinks/roots_controller.rb:88:in `create'
```
Pull Request #258: Fix crash when adding file attachment to problem

2239 of 6030 relevant lines covered (37.13%)

5.61 hits per line

Relevant lines Covered
6030 RELEVANT LINES 2239 COVERED LINES
5.61 HITS PER LINE
Source Files on fix-file-attachments

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
7446176770 fix-file-attachments Fix crash when adding file attachment to problem Previously, if there was a validation error when adding a file attachment to a problem (e.g. "Filepath has already been taken", "Filepath extension doesn't match file"), then instead of displaying ... Pull #258 tom93 github
37.13
7446177038 fix-file-attachments Merge a59343081 into 57b299d1f Pull #258 web-flow github
37.13
7446098143 fix-file-attachments Fix crash when adding file attachment to problem Previously, if there was a validation error when adding a file attachment to a problem (e.g. "Filepath has already been taken", "Filepath extension doesn't match file"), then instead of displaying ... Pull #258 tom93 github
37.13
7445850828 fix-file-attachments WIP: fix crash when adding file attachment to problem There was an incomplete rename in commit 1e931189 (enable file attachments for problems, with shared code for filelinks of groups and problems, 2013-12-19). Triggers error when trying to add a... push tom93 github
37.13
See All Builds (1144)