NZOI / nztrain

33%

master: 38%

LAST BUILD ON BRANCH fix-ambiguous-matches-in-submission-spec

branch: fix-ambiguous-matches-in-submission-spec

CHANGE BRANCH

x

Reset

• fix-ambiguous-matches-in-submission-spec
• master
• zip.fix
• judging-overhaul
• rails.4
• fixes
• thomas-experiment
• NZIC-link-fix
• dependabot/bundler/loofah-2.3.1
• add-javascript-into-master
• migrations-timestamps-null
• fix-bundle-whenever
• fix-submissions-spec
• add-contest-exporter
• deployed-merged-into-master
• dependabot/bundler/rack-protection-1.5.5
• dependabot/bundler/sprockets-3.7.2
• dependabot/bundler/ffi-1.12.2
• dependabot/bundler/nokogiri-1.10.8
• dependabot/bundler/rubyzip-1.3.0
• simplify-commands
• deployed
• reduce-language-installs
• update-rspec-3.9
• dependabot-test-merge-all
• dependabot/bundler/jquery-rails-3.1.3
• convert-specs-with-transpec
• show-all-public-on-scoreboard
• add-pypy
• fix-inspection-formating
• nice-messages
• scoreboard-update
• contests-owner-column
• contests-duration-units
• fix-statement-visibility-in-importer
• contests-owner-on-show-page
• remove-maxmind-geoip
• apt-get-update-before-install
• fix-type-mismatch-in-by-user-param
• refactor-logic-for-hiding-scores-below-median
• fix-current-user-detection-on-scoreboard
• hide-scores-of-deleted-users-below-median
• forbid-commas-in-submissions-route
• dependabot/bundler/geocoder-1.6.1
• dependabot/bundler/json-2.3.1
• dependabot/bundler/mechanize-2.7.7
• fix-redis-installer
• zero-score-message
• scoreboard-update-v2
• school-management
• dependabot/bundler/carrierwave-1.3.2
• update-registration
• disable-school
• fix-inspection-formatting-float-right-v2
• contest-form-validation
• inspect-formatting-remove-repeat
• disable-async-javascript
• scoreboard-refresh-ajax
• server-sidebar-init
• add-contest-exporter-v2
• gh-actions-v2
• ci-test
• tom93/ci-test-simplecov
• tom93/ci-test
• gh-actions-v2-rebase-1
• gh-actions-v2-suggestions
• gh-actions-v3
• archive-migrations
• gemfile-production-group
• remove-nokogiri-deps
• gemfile-assets-group
• gh-actions-skip-assets-gems
• yui-switch-to-jre
• 01-06-Upgrade_has_scope
• gh-actions-diff-schema
• seed-mailer-settings
• 12-30-Add_a_tiny_spec_for_the_file_attachments_page
• sync-rails-config-v2
• 01-05-Update_devise
• skip-wkhtmltopdf-in-ci
• schema-limit-255
• readme-markdown
• fix-file-attachments
• fix-filelink-path-404
• fix-submissions-signed-out
• clean-up-submissions-index
• interactive-problems
• compiled-evaluators
• dependabot/bundler/rmagick-5.3.0
• dependabot/bundler/jquery-rails-4.4.0
• actions/checkout-4
• pin-isolate-1.10.1
• improve-judging-errors

Build # 847

Build Type

Pull #92

travis-ci

Committed by web-flow

Commit Message

Fix ambiguous selector in submission spec

Failure:

  1) submission submit code for a problem
     Failure/Error: find(:select,'submission_language_id').find(:xpath, "//option[@value=#{LanguageGroup.find_by_identifier("c++").current_language.id}]").select_option
     Capybara::Ambiguous:
       Ambiguous match, found 2 elements matching visible xpath "//option[@value=4]" within #<Capybara::Node::Element tag="select" path="/html/body/div[2]/div[2]/div/form[1]/div[2]/select">
     # ./spec/features/submissions_spec.rb:13:in `block (4 levels) in <top (required)>'
     # ./spec/features/submissions_spec.rb:12:in `block (3 levels) in <top (required)>'
     # ./spec/features/submissions_spec.rb:11:in `block (2 levels) in <top (required)>'

The problem is that the XPath expression "//..." searches anywhere in
the document, not just within the current element (see
https://github.com/teamcapybara/capybara#beware-the-xpath--trap).

The ambiguity arises because there are two forms on the submission
page (Upload and Paste), and both of them have a C++ option.

A possible fix is to change the expression to ".//...", but switching
to a CSS selector is simpler.

Co-Authored-By: Tom Levy <tomlevy93@gmail.com>

Pull Request Pull Request #92: Fix ambiguous matches in submission spec

Run Details

45 of 45 new or added lines in 15 files covered. (100.0%)

2325 of 7016 relevant lines covered (33.14%)

4.8 hits per line