NZOI / nztrain / 14614203362

38%

master: 38%

Pull #291

github

Remove unused actions on ContestRelationsController

Most of these actions were rendered unused in 2da020ef59c5, #destroy was
restored and #update_year_level added in 00c9636d1364. The rest of these
sections seem to be dead code, so lets remove them! Git history can
always bring them back as needed, but none of the code is particularly
interesting so it'd be easy to rewrite, anyway.

I've also specs to cover off the major functions of
contest_relations_controller, including some permission tests, and
ensured that there is at least a logged in user to slightly mitigate a
leak of information in the response differing between not_found and
unathorised on ContestRelation objects.

7 of 8 new or added lines in 1 file covered. (87.5%)

2274 of 5915 relevant lines covered (38.44%)

5.78 hits per line