NZOI / nztrain

33%

master: 38%

LAST BUILD ON BRANCH migrations-timestamps-null

branch: migrations-timestamps-null

CHANGE BRANCH

x

Reset

• migrations-timestamps-null
• master
• zip.fix
• judging-overhaul
• rails.4
• fixes
• thomas-experiment
• NZIC-link-fix
• dependabot/bundler/loofah-2.3.1
• add-javascript-into-master
• fix-bundle-whenever
• fix-submissions-spec
• add-contest-exporter
• deployed-merged-into-master
• fix-ambiguous-matches-in-submission-spec
• dependabot/bundler/rack-protection-1.5.5
• dependabot/bundler/sprockets-3.7.2
• dependabot/bundler/ffi-1.12.2
• dependabot/bundler/nokogiri-1.10.8
• dependabot/bundler/rubyzip-1.3.0
• simplify-commands
• deployed
• reduce-language-installs
• update-rspec-3.9
• dependabot-test-merge-all
• dependabot/bundler/jquery-rails-3.1.3
• convert-specs-with-transpec
• show-all-public-on-scoreboard
• add-pypy
• fix-inspection-formating
• nice-messages
• scoreboard-update
• contests-owner-column
• contests-duration-units
• fix-statement-visibility-in-importer
• contests-owner-on-show-page
• remove-maxmind-geoip
• apt-get-update-before-install
• fix-type-mismatch-in-by-user-param
• refactor-logic-for-hiding-scores-below-median
• fix-current-user-detection-on-scoreboard
• hide-scores-of-deleted-users-below-median
• forbid-commas-in-submissions-route
• dependabot/bundler/geocoder-1.6.1
• dependabot/bundler/json-2.3.1
• dependabot/bundler/mechanize-2.7.7
• fix-redis-installer
• zero-score-message
• scoreboard-update-v2
• school-management
• dependabot/bundler/carrierwave-1.3.2
• update-registration
• disable-school
• fix-inspection-formatting-float-right-v2
• contest-form-validation
• inspect-formatting-remove-repeat
• disable-async-javascript
• scoreboard-refresh-ajax
• server-sidebar-init
• add-contest-exporter-v2
• gh-actions-v2
• ci-test
• tom93/ci-test-simplecov
• tom93/ci-test
• gh-actions-v2-rebase-1
• gh-actions-v2-suggestions
• gh-actions-v3
• archive-migrations
• gemfile-production-group
• remove-nokogiri-deps
• gemfile-assets-group
• gh-actions-skip-assets-gems
• yui-switch-to-jre
• 01-06-Upgrade_has_scope
• gh-actions-diff-schema
• seed-mailer-settings
• 12-30-Add_a_tiny_spec_for_the_file_attachments_page
• sync-rails-config-v2
• 01-05-Update_devise
• skip-wkhtmltopdf-in-ci
• schema-limit-255
• readme-markdown
• fix-file-attachments
• fix-filelink-path-404
• fix-submissions-signed-out
• clean-up-submissions-index
• interactive-problems
• compiled-evaluators
• dependabot/bundler/rmagick-5.3.0
• dependabot/bundler/jquery-rails-4.4.0
• actions/checkout-4
• pin-isolate-1.10.1
• improve-judging-errors

Build # 724

Build Type

Pull #69

travis-ci

Committed by web-flow

Commit Message

Set null attribute of timestamps in migrations to match schema

Rails has flipped the default back and forth between `null: true` and
`null: false` (full history below). As a result, our database schema
has a mixture of them.

Explicitly set `null: true` or `null: false` in the migrations to
reliably match the current schema.

Rails History:

 - In Rails 3.2 the default was changed to `null: false`.
   Release notes: https://guides.rubyonrails.org/3_2_release_notes.html#active-record
   Pull request: #3334
   Commit: 3dbedd282

 - In Rails 4.0 this was reverted, with the the explanation that when
   timestamp columns are added to an existing table, the existing
   records don't have timestamps and the "not null" constraint fails
   Commit: fcef72890
   Commit: ccf7cd05a (pull request #7095)

 - In Rails 4.2, `timestamps` without an explicit `null` option was
   deprecated in preparation for making `null: false` the default
   Release notes: https://guides.rubyonrails.org/4_2_release_notes.html#active-record-deprecations
   Pull request: #16481

 - In Rails 5, the default was changed back to `null: false`
   Release notes: https://guides.rubyonrails.org/5_0_release_notes.html#active-record-notable-changes
   Commit: a939506f2

Pull Request Pull Request #69: Fix null attributes of timestamps to match server

Run Details

2309 of 6982 relevant lines covered (33.07%)

4.69 hits per line