NZOI / nztrain

37%

master: 38%

LAST BUILD ON BRANCH remove-permitted-params-caching

branch: remove-permitted-params-caching

CHANGE BRANCH

x

Reset

• remove-permitted-params-caching
• 01-05-Update_devise
• 01-06-Upgrade_has_scope
• 07-19-adjust_default_controller_spec_helper_params_to_never_be_nil
• 12-30-Add_a_tiny_spec_for_the_file_attachments_page
• 303-activerecordstatementinvalid-pgundefinedtable-error-missing-from-clause-entry-for-table-contest_relation
• 321-actionviewtemplateerror-undefined-method-new-for-bigdecimalclass
• NZIC-link-fix
• actions/checkout-4
• actions/ubuntu-22.04
• actions/ubuntu-latest
• add-contest-exporter
• add-contest-exporter-v2
• add-javascript-into-master
• add-puma
• add-pypy
• apt-get-update-before-install
• archive-migrations
• before-action-cont
• better-expand-maybe
• better-expand-maybe-v2
• branch-deploy
• cap3
• change-mailer-address
• change-mailer-templates
• ci-test
• class-names-are-strings
• clean-up-submissions-index
• compiled-evaluators
• contest-after-save-with-spec
• contest-form-validation
• contest-relations
• contests-duration-units
• contests-owner-column
• contests-owner-on-show-page
• convert-specs-with-transpec
• dependabot-test-merge-all
• dependabot/bundler/carrierwave-1.3.2
• dependabot/bundler/ffi-1.12.2
• dependabot/bundler/geocoder-1.6.1
• dependabot/bundler/jquery-rails-3.1.3
• dependabot/bundler/jquery-rails-4.4.0
• dependabot/bundler/json-2.3.1
• dependabot/bundler/loofah-2.3.1
• dependabot/bundler/mechanize-2.7.7
• dependabot/bundler/nokogiri-1.10.8
• dependabot/bundler/rack-protection-1.5.5
• dependabot/bundler/rmagick-5.3.0
• dependabot/bundler/rubyzip-1.3.0
• dependabot/bundler/sprockets-3.7.2
• deployed
• deployed-merged-into-master
• disable-async-javascript
• disable-school
• feature/subtask-scoring
• fewer-ci-runs
• fix-ambiguous-matches-in-submission-spec
• fix-bundle-whenever
• fix-current-user-detection-on-scoreboard
• fix-file-attachments
• fix-filelink-path-404
• fix-inspection-formating
• fix-inspection-formatting-float-right-v2
• fix-problemset-truncation
• fix-redis-installer
• fix-statement-visibility-in-importer
• fix-submissions-signed-out
• fix-submissions-spec
• fix-type-mismatch-in-by-user-param
• fixes
• forbid-commas-in-submissions-route
• formats-and-routes
• gemfile-assets-group
• gemfile-production-group
• gh-actions-diff-schema
• gh-actions-skip-assets-gems
• gh-actions-v2
• gh-actions-v2-rebase-1
• gh-actions-v2-suggestions
• gh-actions-v3
• graphite-base/290
• graphite-base/292
• graphite-base/296
• graphite-base/297
• graphite-base/298
• graphite-base/300
• graphite-base/302
• graphite-base/314
• graphite-base/315
• graphite-base/338
• graphite-base/339
• hide-scores-of-deleted-users-below-median
• ignore-ds
• improve-judging-errors
• inspect-formatting-remove-repeat
• interactive-problems
• judging-overhaul
• less-deprecation-warnings
• loofah-rails-5
• mailer-links-use-https
• master
• migration-version
• migrations-timestamps-null
• nginx-installer-https
• nice-messages
• pin-isolate-1.10.1
• pr/remove-hard-coded-nztrain-email
• problem-browing-spec
• public-file-server
• puma
• pygments-2.3.1
• qless
• qless-log-level
• rails-4-1-session-store
• rails-5
• rails-5-0-deprecations
• rails-5-1
• rails-5-before-callback-return
• rails-5-cleanup
• rails-5-deprecations
• rails-5-suggestions
• rails-5-suggestions-v2
• rails.4
• readme-markdown
• redis-installer-cleanup
• redis-installer-fix-pin-7-4-4
• reduce-language-installs
• refactor-logic-for-hiding-scores-below-median
• remove-alias-method-chain
• remove-asset-compressors
• remove-coffeescript
• remove-contest-finish-at-with
• remove-j
• remove-jquery-historyjs
• remove-maxmind-geoip
• remove-newrelic
• remove-nokogiri-deps
• remove-sass
• remove-squeel
• remove-strong-presenters
• remove-test-cases-test-sets
• remove-transaction-callback
• rspec-persistence-path
• schema-limit-255
• school-management
• scoreboard-reduce-db-queries
• scoreboard-refresh-ajax
• scoreboard-update
• scoreboard-update-v2
• seed-mailer-settings
• seeds
• sentry-apm
• sentry-raven-migration
• server-sidebar-init
• show-all-public-on-scoreboard
• simplify-commands
• skip-wkhtmltopdf-in-ci
• staging
• standarddb-fixes-extra
• standarddb-fixes-manual
• standardrb-1.0.5
• standardrb-fixes
• standardrb-fixes-extra
• standardrb-fixes-manual
• sync-rails-config-v2
• thomas-experiment
• tom93/ci-test
• tom93/ci-test-simplecov
• ubuntu-noble
• update-bundler-1-17
• update-devise-config
• update-json
• update-python
• update-registration
• update-rspec-3.9
• vendor-jquery
• write-out-facebox
• write-out-fixtures-spec-helper
• yui-switch-to-jre
• zero-score-message
• zip.fix

Build # 14556368249

Build Type

Pull #289

github

Committed by tom93

Commit Message

Remove caching from controller permitted_params etc.

We don't call these methods multiple times during a single request, so
there is no point in caching the result. (The example from the
original strong_parameters gem doesn't use caching:
https://github.com/rails/strong_parameters.)

This also eliminates silly inconsistencies with what was cached -- in
some places it was @_permitted_params, while in other places it was
the intermediate @_permitted_attributes.

Also remove method `visible_attributes` from user_controller.rb, it's
unused since commit 8798951a (Refactor to remove the UserPresenter
service object (#165), 2023-02-18).

Pull Request Pull Request #289: Remove caching from controller permitted_params etc.

Run Details

32 of 51 new or added lines in 16 files covered. (62.75%)

4 existing lines in 4 files now uncovered.

2243 of 5990 relevant lines covered (37.45%)

5.65 hits per line