• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

MushroomObserver / mushroom-observer / 26695508853
97%
main: 99%

Build:
Build:
LAST BUILD BRANCH: nimmo-i18n-titlecase-typo-sweep
DEFAULT BRANCH: main
Ran 30 May 2026 09:38PM UTC
Jobs 1
Files 1056
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 May 2026 09:34PM UTC coverage: 96.513% (+0.02%) from 96.49%
26695508853

Pull #4398

github

nimmolo
visual_groups + visual_models: convert the rest of the folder to Phlex; extend Table#column with arbitrary HTML attrs

Expands #4398's scope per review feedback. The original PR converted only `visual_groups/edit.html.erb` and bridged the rest via `view_context.render(partial: …)`. This commit finishes the conversion across both folders — visual_models is admin-only and parallels the visual_groups shape, so doing both at once keeps the bridge code from lingering.

**New Phlex action views:**
- `Views::Controllers::VisualGroups::Show`
- `Views::Controllers::VisualGroups::Index` (delegates to the shared visual-group table)
- `Views::Controllers::VisualGroups::New`
- `Views::Controllers::VisualModels::Index` (uses `Components::Table`)
- `Views::Controllers::VisualModels::Show` (delegates to the shared table)
- `Views::Controllers::VisualModels::New`
- `Views::Controllers::VisualModels::Edit`

**New shared Phlex views:**
- `Views::Controllers::VisualGroups::ImageMatrix` — image-matrix grid for both edit + show; renders one `StatusLinks` per image.
- `Views::Controllers::VisualGroups::StatusLinks` — per-image status-buttons block (needs-review / include / exclude trio + image-id link). Rendered both inside the matrix grid AND as the body of the `visual_groups/images#update` turbo-stream replace response, so the same Phlex unit drives both the initial render and the post-click swap.
- `Views::Controllers::VisualModels::VisualGroupTable` — the visual-groups-of-a-model table, rendered by `VisualModels::Show` and `VisualGroups::Index`. Uses `Components::Table` for the table-shell + per-column wiring (removes the hand-rolled `<thead>` / `<tbody>` markup).

**Components::Table extension:** `Table#column` now accepts arbitrary HTML attrs (`width: "33%"`, `data: { ... }`, etc.) in addition to the existing `class:`, and forwards them to both the `<th>` and `<td>` for that column. Lets the `VisualModels::Index` table preserve its `width="33%"` cell sizing without go... (continued)
Pull Request #4398: visual_groups: convert edit.html.erb to Phlex

290 of 290 new or added lines in 15 files covered. (100.0%)

40050 of 41497 relevant lines covered (96.51%)

667.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 26695508853.1 30 May 2026 09:38PM UTC 1056
96.51
GitHub Action Run
Source Files on build 26695508853
  • Tree
  • List 1056
  • Changed 4
  • Source Changed 4
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #26695508853
  • Pull Request #4398
  • PR Base - main (#26682743178)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc