ruby-grape / grape
97%
master: 97%

Repo Added 04 Apr 2013 06:08AM UTC

Committed 03 Sep 2026 03:06PM UTC coverage: 96.955%. First build

Committed by

Commit Message

Read the request method once in default_status

`default_status` supplies the status for every response that did not set one,
and asked the request twice for the same thing:

    return 201 if request.post?
    return 204 if request.delete? && @body.blank?

`Rack::Request::Helpers#post?` and `#delete?` are each `request_method == ...`,
so a GET — the common case, and the one that reaches the third line — walked
`request`, `request_method` and the env twice over.

    post? + delete?  158.4 ns  ->  request_method  90.7 ns   1.75x

End to end this is at the edge of what an interleaved `Benchmark.ips` run
resolves (+1.4% on a minimal versioned GET, median of 5), so the per-call
figure above is the honest measurement.

Five examples in `inside_route_spec` asserted `receive(:request).twice`, which
pinned how many times `default_status` reads the request rather than what it
answers. They keep the stub and drop the count.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

1244 of 1338 branches covered (92.97%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

3946 of 4015 relevant lines covered (98.28%)

26980.1 hits per line

4015 RELEVANT LINES 3946 COVERED LINES

26980.1 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
33770784643	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	Pull #2894	03 Sep 2026 03:07PM UTC	ericproulx	github	96.95
33759992068	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	Pull #2894	03 Sep 2026 01:17PM UTC	ericproulx	github	96.95
33728818814	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	Pull #2894	03 Sep 2026 07:36AM UTC	ericproulx	github	96.97
33727246955	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	Pull #2894	03 Sep 2026 07:21AM UTC	ericproulx	github	96.97
33686824992	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	Pull #2894	02 Sep 2026 10:00PM UTC	ericproulx	github	96.94
33686641563	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	push	02 Sep 2026 09:52PM UTC	ericproulx	github	96.94
33686459006	perf/default-status-single-read	Read the request method once in default_status `default_status` supplies the status for every response that did not set one, and asked the request twice for the same thing: return 201 if request.post? return 204 if request.delete? && @bo...	push	02 Sep 2026 09:43PM UTC	ericproulx	github	96.94

ruby-grape / grape
97%
master: 97%

ruby-grape / grape 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on perf/default-status-single-read

Recent builds

ruby-grape / grape
97%
master: 97%

README BADGES
x

CHANGE BRANCH
x