ruby-grape / grape / 33728818814

97%

master: 97%

Pull #2894

github

Read the request method once in default_status

`default_status` supplies the status for every response that did not set one,
and asked the request twice for the same thing:

    return 201 if request.post?
    return 204 if request.delete? && @body.blank?

`Rack::Request::Helpers#post?` and `#delete?` are each `request_method == ...`,
so a GET — the common case, and the one that reaches the third line — walked
`request`, `request_method` and the env twice over.

    post? + delete?  158.4 ns  ->  request_method  90.7 ns   1.75x

End to end this is at the edge of what an interleaved `Benchmark.ips` run
resolves (+1.4% on a minimal versioned GET, median of 5), so the per-call
figure above is the honest measurement.

Five examples in `inside_route_spec` asserted `receive(:request).twice`, which
pinned how many times `default_status` reads the request rather than what it
answers. They keep the stub and drop the count.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1238 of 1332 branches covered (92.94%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

3938 of 4006 relevant lines covered (98.3%)

27123.32 hits per line