ruby-grape / grape
97%
master: 99%

LAST BUILD BRANCH: update_rubocop_1_90
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH route-param-bare-requirements
branch: route-param-bare-requirements
CHANGE BRANCH
x

coverage: 97.157% (+0.005%) from 97.152%
33984725908

Pull #2905

github

dblock 
Nest any route_param requirement, and reject the shapes with no param to attach to

`route_param` nested a lone `requirements:` under the param name only when it
was a Regexp — the shorthand as it was written in 2013, when a Regexp was the
only kind of constraint there was. Anything else, such as the capture types
Mustermann derives from a Class or a Symbol, travelled unwrapped into
`Endpoint#prepare_routes_requirements`, which merges the requirement Hashes of
the namespaces a route sits in, and raised `TypeError: no implicit conversion
of Class into Hash` there. That merge runs when routes are built, so a mistake
in the API's definition surfaced on the first request, from a method that
names neither the route nor the requirement.

Nesting the constraint is what `route_param` is for, so it now nests whatever
it is given. A Hash is refused: keyed by this param it names it twice, and
keyed by another it constrains a capture the namespace does not introduce,
which Mustermann resolves to no constraint at all. Requirements keyed by name
belong on `namespace`, which is also where they are merged.

`namespace` and an endpoint have the opposite constraint — a path can carry
several captures, so there is no param a lone constraint could attach to — and
now reject a non-Hash `requirements` where it is written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2905: Nest any route_param requirement, and reject the shapes with no param to attach to

1245 of 1334 branches covered (93.33%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

3950 of 4013 relevant lines covered (98.43%)

27226.91 hits per line

Relevant lines Covered
4013 RELEVANT LINES 3950 COVERED LINES
27226.91 HITS PER LINE
Source Files on route-param-bare-requirements

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33984725908 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 dblock github
97.16
33963086412 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33962974598 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33962750950 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33962732647 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... push ericproulx github
97.16
33962140237 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33962056060 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33961783258 route-param-bare-requirements Nest any route_param requirement, and reject the shapes with no param to attach to `route_param` nested a lone `requirements:` under the param name only when it was a Regexp — the shorthand as it was written in 2013, when a Regexp was the only ki... Pull #2905 ericproulx github
97.16
33958323629 route-param-bare-requirements Nest any lone route_param requirement, and reject a non-Hash elsewhere `route_param` nested a lone `requirements:` under the param name only when it was a Regexp. Every other constraint — a capture type such as `Integer` or `:date` — travelled un... Pull #2905 ericproulx github
97.16
33925937310 route-param-bare-requirements Nest any lone route_param requirement, and reject a non-Hash elsewhere `route_param` nested a lone `requirements:` under the param name only when it was a Regexp. Every other constraint — a capture type such as `Integer` or `:date` — travelled un... Pull #2905 ericproulx github
97.01
See All Builds (3806)