ruby-grape / grape
97%
master: 99%

Repo Added 04 Apr 2013 06:08AM UTC

Committed 06 Sep 2026 11:01AM UTC coverage: 97.157%. Remained the same

Committed by

Commit Message

Stop reassigning method parameters across lib

A parameter reassigned partway through a method means the name documents
one thing in the signature and holds another below it. Every site in
`lib` now binds the derived value to its own local, so a parameter keeps
what the caller passed for the whole method.

Two of them were reassigned to hide a mutation of the argument itself,
and those stop writing into what they were given:

* `Middleware::Formatter#ensure_content_type` merged a Content-Type into
  the response headers Hash in place, then returned it.
* `ParamsScope#process_oneof!` wrote the collected variants back into the
  options Hash from the `requires`/`optional` call site. Now
  `#collected_oneof` returns them and the caller merges.

`Endpoint::Options` is left alone; it is fixed in #2907.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

1245 of 1334 branches covered (93.33%)

Branch coverage included in aggregate %.

74 of 75 new or added lines in 16 files covered. (98.67%)

3950 of 4013 relevant lines covered (98.43%)

27098.72 hits per line

4013 RELEVANT LINES 3950 COVERED LINES

27098.72 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
34029068515	no-param-reassign-error-middleware	Stop reassigning method parameters across lib A parameter reassigned partway through a method means the name documents one thing in the signature and holds another below it. Every site in `lib` now binds the derived value to its own local, so a p...	Pull #2908	06 Sep 2026 11:02AM UTC	ericproulx	github	97.16
33984343304	no-param-reassign-error-middleware	Stop reassigning method parameters across lib A parameter reassigned partway through a method means the name documents one thing in the signature and holds another below it. Every site in `lib` now binds the derived value to its own local, so a p...	Pull #2908	05 Sep 2026 06:31PM UTC	ericproulx	github	97.11
33983407847	no-param-reassign-error-middleware	Stop reassigning parameters in the error middleware `rack_response` overwrote its `message` parameter with the escaped copy and `run_rescue_handler` overwrote its `handler` parameter with the `Method` it resolved a Symbol to. Both now assign to a...	Pull #2908	05 Sep 2026 06:14PM UTC	ericproulx	github	97.11
33982863480	no-param-reassign-error-middleware	Merge 10e61b1a8 into 17bf34581	Pull #2908	05 Sep 2026 06:03PM UTC	web-flow	github	97.11
33982826340	no-param-reassign-error-middleware	Stop reassigning parameters in the error middleware `rack_response` overwrote its `message` parameter with the escaped copy and `run_rescue_handler` overwrote its `handler` parameter with the `Method` it resolved a Symbol to. Both now assign to a...	push	05 Sep 2026 06:03PM UTC	ericproulx	github	97.11

ruby-grape / grape
97%
master: 99%

ruby-grape / grape 97% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on no-param-reassign-error-middleware

Recent builds

ruby-grape / grape
97%
master: 99%

README BADGES
x

CHANGE BRANCH
x