ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: refactor/de-morgan-conditions
DEFAULT BRANCH: master
Repo Added
Files 157
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/de-morgan-conditions
branch: SELECT
CHANGE BRANCH
x

coverage: 97.007% (+0.02%) from 96.985%
25610885355

Pull #2707

github

ericproulx 
Tighten six guard conditions via De Morgan / blank? / present? / include?

Six spots where an `if`/`unless` clause used multiple negations
joined by `&&` or `||`, or `&.any?` on a Hash. Each rewrite expresses
the positive shape of the predicate and keeps `if` over `unless`
where natural. Same behaviour, same allocation profile (one form
even reuses a previously-recomputed `Hash#except` result).

* `Grape::API::Boolean.build` —
  `val != true && val != false` → frozen `VALUES` constant +
  `unless VALUES.include?(val)`.

* `Grape::Request#make_params` —
  `routing_args&.any? { |k, _| k != :version && k != :route_info }` +
  separate `routing_args.except(:version, :route_info)` two lines
  later → compute `except` once, gate on `filtered.blank?`.

* `Grape::Validations::ParamsScope#check_incompatible_option_values`
  (early guard) —
  `return unless default && !default.is_a?(Proc)` →
  `return if default.nil? || default.is_a?(Proc)`.

* `Grape::Validations::ParamsScope#check_incompatible_option_values`
  (raise condition) —
  `!Array(default).all? { |v| values.include?(v) }` →
  `Array(default).any? { |v| !values.include?(v) }`.

* `Grape::Validations::Validators::Base#scrub` —
  `unless value.respond_to?(:valid_encoding?) && !value.valid_encoding?`
  → `if !value.respond_to?(:valid_encoding?) || value.valid_encoding?`.

* `Grape::DSL::Routing#route` —
  `route_options&.any?` → `route_options.present?`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2707: Tighten five guard conditions via De Morgan / blank? / include?

1082 of 1165 branches covered (92.88%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 5 files covered. (100.0%)

3423 of 3479 relevant lines covered (98.39%)

32165.44 hits per line

Relevant lines Covered
3479 RELEVANT LINES 3423 COVERED LINES
32165.44 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25610885355 refactor/de-morgan-conditions Tighten six guard conditions via De Morgan / blank? / present? / include? Six spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`, or `&.any?` on a Hash. Each rewrite expresses the positive shape of the predicate an... Pull #2707 ericproulx github
97.01
25610832363 refactor/de-morgan-conditions Tighten five guard conditions via De Morgan / blank? / include? Five spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`. Each rewrite expresses the positive shape of the predicate and keeps `if` over `unless` where... Pull #2707 ericproulx github
96.99
25610816166 refactor/de-morgan-conditions Merge 28a97e1ab into 037476e62 Pull #2707 web-flow github
96.99
25610805204 refactor/de-morgan-conditions Tighten five guard conditions via De Morgan / blank? / include? Five spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`. Each rewrite expresses the positive shape of the predicate and keeps `if` over `unless` where... push ericproulx github
96.99
25610530583 refactor/validates-pure-helpers Make ParamsScope#validates pure via ValidationsSpec `Grape::Validations::ParamsScope#validates(attrs, validations)` used to consume the validations hash destructively across six helpers (`infer_coercion`, `derive_validator_options`, `validates_pr... Pull #2706 ericproulx github
96.99
25610457229 refactor/validates-pure-helpers Make ParamsScope#validates pure via ValidationsSpec `Grape::Validations::ParamsScope#validates(attrs, validations)` used to consume the validations hash destructively across six helpers (`infer_coercion`, `derive_validator_options`, `validates_pr... Pull #2706 ericproulx github
96.99
25610197149 refactor/validates-pure-helpers Make ParamsScope#validates pure via ValidationsSpec `Grape::Validations::ParamsScope#validates(attrs, validations)` used to consume the validations hash destructively across six helpers (`infer_coercion`, `derive_validator_options`, `validates_pr... Pull #2706 ericproulx github
96.99
25609976233 refactor/validates-pure-helpers Make ParamsScope#validates pure via ValidationsSpec `Grape::Validations::ParamsScope#validates(attrs, validations)` used to consume the validations hash destructively across six helpers (`infer_coercion`, `derive_validator_options`, `validates_pr... Pull #2706 ericproulx github
96.99
25609944548 refactor/validates-pure-helpers Merge 46da66095 into 037476e62 Pull #2706 web-flow github
96.99
25609895419 refactor/validates-pure-helpers Make ParamsScope#validates pure via ValidationsSpec `Grape::Validations::ParamsScope#validates(attrs, validations)` used to consume the validations hash destructively across six helpers (`infer_coercion`, `derive_validator_options`, `validates_pr... push ericproulx github
96.99
See All Builds (2888)