ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: no-param-reassign-error-middleware
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH error-formatter-nil-guard
branch: error-formatter-nil-guard
CHANGE BRANCH
x

coverage: 97.109% (+0.04%) from 97.072%
33958045014

Pull #2901

github

ericproulx 
Require a formatter in error_formatter and drop the unreachable 406 throw

`error_formatter :json` — with no formatter, positionally or as `with:` —
registered `nil`. `ErrorFormatter.formatter_for` returns a registered value
verbatim through its `key?` short-circuit, so that format resolved to no
formatter at all, and `Middleware::Error#format_message` fell through to a
`throw :error, 406`.

That throw could never deliver its 406: nothing catches `:error` around the
call. `#call!` has already left its `catch` by the time `error_response` runs,
and `run_rescue_handler` renders outside its own. So it raised
`UncaughtThrowError`, `render_response` rescued it, and the request answered
with the failsafe `500 Internal Server Error` in `text/plain` instead of the
status and message the API asked for.

Raise `ArgumentError` from the DSL when no formatter is given, so the mistake
surfaces where it is made, and drop the dead branch — `formatter_for` always
resolves to a registered formatter, `default_error_formatter` or
`ErrorFormatter::Txt`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2901: Require a formatter in error_formatter and drop the unreachable 406 throw

1238 of 1328 branches covered (93.22%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

3935 of 3999 relevant lines covered (98.4%)

27216.16 hits per line

Relevant lines Covered
3999 RELEVANT LINES 3935 COVERED LINES
27216.16 HITS PER LINE
Source Files on error-formatter-nil-guard

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33958045014 error-formatter-nil-guard Require a formatter in error_formatter and drop the unreachable 406 throw `error_formatter :json` — with no formatter, positionally or as `with:` — registered `nil`. `ErrorFormatter.formatter_for` returns a registered value verbatim through its `... Pull #2901 ericproulx github
97.11
33924285829 error-formatter-nil-guard Require a formatter in error_formatter and drop the unreachable 406 throw `error_formatter :json` — with no formatter, positionally or as `with:` — registered `nil`. `ErrorFormatter.formatter_for` returns a registered value verbatim through its `... Pull #2901 ericproulx github
97.0
33921915988 error-formatter-nil-guard Require a formatter in error_formatter and drop the unreachable 406 throw `error_formatter :json` — with no formatter, positionally or as `with:` — registered `nil`. `ErrorFormatter.formatter_for` returns a registered value verbatim through its `... Pull #2901 ericproulx github
97.0
33921897133 error-formatter-nil-guard Require a formatter in error_formatter and drop the unreachable 406 throw `error_formatter :json` — with no formatter, positionally or as `with:` — registered `nil`. `ErrorFormatter.formatter_for` returns a registered value verbatim through its `... Pull #2901 ericproulx github
97.0
See All Builds (3760)