ruby-grape / grape
100%
master: 100%

LAST BUILD BRANCH: dblock/automate-gem-release
DEFAULT BRANCH: master
Repo Added
Files 179
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH translator-seam
branch: translator-seam
CHANGE BRANCH
x

coverage: 99.916% (-0.05%) from 99.966%
36520941629

Pull #2980

github

ericproulx 
Resolve error messages through a translator

Grape::Util::Translation called I18n directly, so every error message was
an I18n lookup and nothing else was possible. It now hands the lookup to
Grape.translator, and ships two that answer it.

Grape::Translator::I18n is the default and is today's code moved, not
changed: it resolves at request time, so the locale in force and an
application's own overrides both apply.

Grape::Translator::Catalog answers from one frozen table instead, built
once from Grape's own locale/en.yml -- read with YAML, so it needs no
I18n -- with whatever I18n has loaded merged over it, so overrides and
other locales are carried. Keys are flat and the interpolation
placeholders are rewritten into the form format takes, so a lookup is a
Hash read and a format. A 400 validation-error response measures 32.2 us
against 53.4 us, 1.66x faster.

What the catalog trades away is in the README: it is a snapshot, so a
locale loaded after it was built is not in it; the locale in force comes
from Grape.locale, which is fiber-local, rather than from I18n; and it
carries the scopes it was asked for, grape by default.

The two are held to each other by a spec that compares every message
Grape ships, with a value supplied for each placeholder, so the one
cannot drift from the other.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2980: Resolve error messages through a translator

1530 of 1534 branches covered (99.74%)

Branch coverage included in aggregate %.

81 of 81 new or added lines in 5 files covered. (100.0%)

4451 of 4452 relevant lines covered (99.98%)

29327.01 hits per line

Relevant lines Covered
4452 RELEVANT LINES 4451 COVERED LINES
29327.01 HITS PER LINE
Source Files on translator-seam

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
36520941629 translator-seam Resolve error messages through a translator Grape::Util::Translation called I18n directly, so every error message was an I18n lookup and nothing else was possible. It now hands the lookup to Grape.translator, and ships two that answer it. Grape:... Pull #2980 ericproulx github
99.92
35716732143 translator-seam Resolve error messages through a translator Grape::Util::Translation called I18n directly, so every error message was an I18n lookup and nothing else was possible. It now hands the lookup to Grape.translator, and ships two that answer it. Grape:... Pull #2980 ericproulx github
98.99
35716386876 translator-seam Resolve error messages through a translator Grape::Util::Translation called I18n directly, so every error message was an I18n lookup and nothing else was possible. It now hands the lookup to Grape.translator, and ships two that answer it. Grape:... Pull #2980 ericproulx github
98.99
35716331984 translator-seam Resolve error messages through a translator Grape::Util::Translation called I18n directly, so every error message was an I18n lookup and nothing else was possible. It now hands the lookup to Grape.translator, and ships two that answer it. Grape:... push ericproulx github
98.99
See All Builds (4533)