ruby-grape / grape
97%
master: 100%

LAST BUILD BRANCH: chore/clear-rubocop-todo
DEFAULT BRANCH: master
Repo Added
Files 176
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/error-rendering-failsafe
branch: fix/error-rendering-failsafe
CHANGE BRANCH
x

coverage: 96.991% (-0.004%) from 96.995%
32583282788

Pull #2840

github

ericproulx 
Expose a swallowed exception on rack.exception in safe_default too (#2855)

safe_default is the unrecognised-error path: an exception raised inside a
rescue_from block that nothing else handles. Grape answers a generic 500 there
rather than letting it propagate, and records the exception on
env['grape.exception'].

That key is Grape's own and no error tracker reads it. Because the exception
never propagates, a tracker mounted above Grape has nothing to catch either, so
a bug in a rescue_from block has always been able to turn into a silent 500 —
the request is answered, the log says nothing, and the tracker never fires.

Publish it on env['rack.exception'] as well, the convention for an exception
that was handled rather than raised, which sentry-ruby collects as
env['rack.exception'] || env['sinatra.error']. Extracted as expose_exception,
now shared with the rendering failsafe.

The deliberate silence of this path is left alone: unlike the failsafe, a
rescue_from :internal_grape_exceptions handler can still own the response here,
so the logging stays the application's call.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2840: Answer 500 when an error response cannot be rendered

1228 of 1318 branches covered (93.17%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 3 files covered. (100.0%)

3865 of 3933 relevant lines covered (98.27%)

27123.77 hits per line

Relevant lines Covered
3933 RELEVANT LINES 3865 COVERED LINES
27123.77 HITS PER LINE
Source Files on fix/error-rendering-failsafe

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32583282788 fix/error-rendering-failsafe Expose a swallowed exception on rack.exception in safe_default too (#2855) safe_default is the unrecognised-error path: an exception raised inside a rescue_from block that nothing else handles. Grape answers a generic 500 there rather than lettin... Pull #2840 ericproulx github
96.99
32583012392 fix/error-rendering-failsafe Expose a swallowed exception on rack.exception in safe_default too (#2855) safe_default is the unrecognised-error path: an exception raised inside a rescue_from block that nothing else handles. Grape answers a generic 500 there rather than lettin... Pull #2840 ericproulx github
96.99
32173808300 fix/error-rendering-failsafe Expose a swallowed exception on rack.exception in safe_default too (#2855) safe_default is the unrecognised-error path: an exception raised inside a rescue_from block that nothing else handles. Grape answers a generic 500 there rather than lettin... Pull #2840 web-flow github
96.98
32108439890 fix/error-rendering-failsafe Answer 500 when an error response cannot be rendered Grape::Middleware::Error#call! renders the error response from inside its own rescue clause, so that clause never covered the rendering. An error formatter that raised on the payload it was han... Pull #2840 ericproulx github
96.98
32106065653 fix/error-rendering-failsafe Answer 500 when an error response cannot be rendered Grape::Middleware::Error#call! renders the error response from inside its own rescue clause, so that clause never covered the rendering. An error formatter that raised on the payload it was han... Pull #2840 ericproulx github
96.98
32044609601 fix/error-rendering-failsafe Answer 500 when an error response cannot be rendered Grape::Middleware::Error#call! renders the error response from inside its own rescue clause, so that clause never covered the rendering. An error formatter that raised on the payload it was han... push ericproulx github
96.97
32037972879 fix/error-rendering-failsafe Merge e0bd77856 into 79c91a84b Pull #2840 web-flow github
96.97
32037970029 fix/error-rendering-failsafe Answer 500 when an error response cannot be rendered Grape::Middleware::Error#call! renders the error response from inside its own rescue clause, so that clause never covered the rendering. An error formatter that raised on the payload it was han... push ericproulx github
96.97
32036877441 fix/error-rendering-failsafe Merge 36b084b4d into 79c91a84b Pull #2840 web-flow github
96.97
32036875440 fix/error-rendering-failsafe Answer 500 when an error response cannot be rendered Grape::Middleware::Error#call! renders the error response from inside its own rescue clause, so that clause never covered the rendering. An error formatter that raised on the payload it was han... push ericproulx github
96.97
See All Builds (4380)