ruby-grape / grape / 32583282788

97%

master: 100%

Pull #2840

github

Expose a swallowed exception on rack.exception in safe_default too (#2855)

safe_default is the unrecognised-error path: an exception raised inside a
rescue_from block that nothing else handles. Grape answers a generic 500 there
rather than letting it propagate, and records the exception on
env['grape.exception'].

That key is Grape's own and no error tracker reads it. Because the exception
never propagates, a tracker mounted above Grape has nothing to catch either, so
a bug in a rescue_from block has always been able to turn into a silent 500 —
the request is answered, the log says nothing, and the tracker never fires.

Publish it on env['rack.exception'] as well, the convention for an exception
that was handled rather than raised, which sentry-ruby collects as
env['rack.exception'] || env['sinatra.error']. Extracted as expose_exception,
now shared with the rendering failsafe.

The deliberate silence of this path is left alone: unlike the failsafe, a
rescue_from :internal_grape_exceptions handler can still own the response here,
so the logging stays the application's call.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1228 of 1318 branches covered (93.17%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 3 files covered. (100.0%)

3865 of 3933 relevant lines covered (98.27%)

27123.77 hits per line