rieske / trans
94%

DEFAULT BRANCH: master
Repo Added
Files 273
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

34136371682

push

github

web-flow 
fix: internal codegen invariants fail in release builds too (#305)

assert is compiled out by NDEBUG, which is the default build type, so
invariants that code generation relies on were unchecked in the build
people actually ship. This is the divergence that hid the Result
annotation bug, where the assert was the only thing between a missing
annotation and dereferencing nullptr.

Nine sites asserted a pointer and then dereferenced it: the declarator
holder, IndexPlan, FieldPlan, the member base symbol, the string literal
rodata label, the postfix PreOperation, the enclosing procedure of a
scratch value, the assigned register, and the operator behind a lexeme.
In a release build a missing one was a null dereference rather than a
diagnosable failure.

Five more asserted and then continued, which is worse than a crash
because it emits wrong assembly and says nothing. Address::frameBase and
offsetBytes answered for a global home with the stack pointer and zero,
so a global reached memoryOperandAt as a frame slot; label() answered for
a frame slot with an empty symbol; and a duplicate frame home
registration was dropped, leaving the value bound to the first home.

All fourteen now raise an internal compiler error in every build type,
matching the guards used for the parse stack, the Result annotation and
the open function scope.

The remaining asserts are left alone: they guard states whose dereference
already routes through a throwing accessor, or that throw of their own
accord.

15851 of 16787 relevant lines covered (94.42%)

153168.45 hits per line

Relevant lines Covered
16787 RELEVANT LINES 15851 COVERED LINES
153168.45 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34136371682 master fix: internal codegen invariants fail in release builds too (#305) assert is compiled out by NDEBUG, which is the default build type, so invariants that code generation relies on were unchecked in the build people actually ship. This is the diver... push web-flow github pending completion  
34134791737 master refactor: fold IfElse and VoidReturn into optional children (#304) IfStatement takes an optional else body (null means no else). ReturnStatement takes an optional expression (null is return;). IfElseStatement and VoidReturnStatement are gone. SA ... push web-flow github
94.47
34132856671 master fix: block-scope extern and enumerator declarations follow C scoping (#303) Five conformance gaps with one theme: a declaration inside a block was treated as if it owned the file-scope entity, and enumerators were checked against ordinary identif... push web-flow github
94.49
34131825391 master refactor: consume tokens by move instead of copying them (#302) Token takes owned strings. The automaton hands the accumulated token and lexeme out by move; Scanner builds the Token. TokenStream classifies in place, and consume() is the one owned... push web-flow github
94.47
34129927830 master refactor: parse operators once into typed enums (#301) Store a closed op type on each expression node instead of the token lexeme. CSNB parses the terminal once; SA, codegen, and integer fold switch on the enum. UnaryOp is + - ! ~ * & sizeof. ++... push web-flow github
94.47
34126608172 master fix: postfix pre-operation slot is a temporary, not a declaration (#300) Naming the slot `<operand>_pre` and inserting it put a compiler temporary in the user identifier namespace. insertSymbol reports a collision through a bool return that was i... push web-flow github
94.42
34125286548 master refactor: one record for the open function scope (#299) SymbolTable kept two members encoding the same fact: functionScopes, a vector that could never exceed size 1 because C has no nested function definitions, and scopeIdStack, the block nesting... push web-flow github
94.42
34118940464 master fix: stop internal errors following a semantic diagnostic (#298) A static initializer whose operand failed analysis printed the real diagnostic and then an internal one: int x = nosuch; -> error: symbol `nosuch` is not defined Err... push web-flow github
94.42
34116200815 master fix: reject declarations that reach code generation with nothing to bind (#297) Two constructs passed semantic analysis and failed later, one of them by crashing. A function declarator carrying an initializer was accepted, then hit CodeGeneratin... push web-flow github
94.42
34111469960 master fix: spill registers before a store through a pointer (#296) A store through a pointer can reach any object whose address escaped, but lvalueAssign emitted the store and left the register file alone. A value read into a register before the store ... push web-flow github
94.41
See All Builds (1233)