facebookincubator / TTPForge / 17239386454

51%

main: 67%

Pull #551

github

TTPForge Move Command (#551)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/551

# Overview
This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact.

# Context
This implementation spawned from a growing need for reorganization within the growing list of available forges.

View T234255665: [TTPForge] Create Move TTP Command for additional information.

# Future Improvements
Currently, regex pattern matching is used to find and update existing references. Aditional testing should be done to confirm that the regex patterns being tested only update the appropriate references. Additional handling could be added for partial path matches in cases were paths are dynamically generated based on variable values.

When specifying a reference path for the destination (repo//path/to/ttp), the current implementation uses the repository's first search path to store the file. This could be improved to look through all of the search paths and find one that is the closest to the provided path.

# Changes
- Added `move` command to the root command.
- `move.go` and `move_test.go hold implementation and testing for the `move` command respectively.
- Separated TTPRef parsing out from TTPRef resolution in `repocollection.go`.
- Updated `AbsPath()` in `fileutils.go` to resolve the actual absolute path following any symlinks.

Reviewed By: RoboticPrism

Differential Revision: D80826527

159 of 241 new or added lines in 5 files covered. (65.98%)

2579 of 3887 relevant lines covered (66.35%)

16.7 hits per line