decentraland / comms-gatekeeper
85%

DEFAULT BRANCH: main
Repo Added
Token H9CF0YzviAGXBYzx8ZZY8Lv8V4wtqKxTm regen
Build 760 Last
Files 148
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 85.261% (-0.04%) from 85.297%
25229256389

push

github

web-flow 
refactor: extract room metadata sync and add scene admins to metadata (#261)

* refactor: extract room metadata sync and add scene admins to metadata

room metadata exposed only banned addresses; clients also need the set
of effective admins to render admin badges and pre-validate admin
actions before hitting the gatekeeper.

a new logic component (src/logic/room-metadata-sync) owns refreshing
scene/world room metadata. it exposes refreshRoomMetadata /
updateRoomMetadataForRoom for full reconciliation, and incremental
addBan / removeBan / addAdmin / removeAdmin that wrap the livekit array
primitives. the four mutation handlers (ban add/remove, admin add/remove)
use the incremental path, which drops 1-2 db queries plus ~3 worlds /
lands http calls per mutation.

webhook-driven refreshes are throttled per room with a 60s cooldown so
participant_joined doesn't trigger a full refresh on every join. the
cooldown is set up-front so concurrent webhooks can't both pass the
gate, and self-prunes stale entries to keep the map bounded.

other fixes folded in:
- livekit.getRoomName falls back to the legacy comms-prefix format for
  worlds without a sceneid (real legacy rooms) and throws for non-world
  without a sceneid. all four mutation paths compute the room name
  before any db write so a strict-throw cannot leave db and metadata
  partially mutated.
- addSceneBan persists the ban first, then runs kick + metadata update
  in parallel as best-effort, so a failed db write no longer leaves a
  participant kicked but unbanned.
- removeSceneAdminHandler lowercases the payload address once after
  EthAddress.validate so a checksum-cased input no longer leaves stale
  entries in the lowercase-keyed metadata array.
- land-lease holders are included in the admins union, with errors
  caught locally so a flaky lease service cannot drop bans / admins
  from the metadata write.

* refactor: use @dcl/memory-cache-component for the webhook refresh cooldown

replaces the lo... (continued)

1061 of 1369 branches covered (77.5%)

Branch coverage included in aggregate %.

170 of 177 new or added lines in 15 files covered. (96.05%)

2994 of 3387 relevant lines covered (88.4%)

75.1 hits per line

Relevant lines Covered
3387 RELEVANT LINES 2994 COVERED LINES
75.1 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25229256389 main refactor: extract room metadata sync and add scene admins to metadata (#261) * refactor: extract room metadata sync and add scene admins to metadata room metadata exposed only banned addresses; clients also need the set of effective admins to re... push web-flow github
85.26
25228902518 refactor/room-metadata-sync fix: release cooldown on webhook-refresh failure; align admin auth status addresses two reviewer comments: - updateRoomMetadataForRoom now removes the cooldown cache key from the catch block. previously a transient place-lookup blip would cons... Pull #261 LautaroPetaccio github
85.26
25228208712 refactor/room-metadata-sync test: add lands mock helper and rewrite the lands spec to convention introduces test/mocks/lands-mock.ts (createLandsMockedComponent) so consumers don't need to inline the full ILandComponent shape. room-metadata-sync.spec.ts now uses it instead ... Pull #261 LautaroPetaccio github
85.26
25227928729 refactor/room-metadata-sync test: fuse the lands and land-lease specs into one file both files were testing the lands component now that land-lease was folded in last commit, and both used the same createLandsComponent factory with overlapping mock setup. merging them remov... Pull #261 LautaroPetaccio github
85.26
25227524513 refactor/room-metadata-sync refactor: fold land-lease into the lands wkc component land-lease was a tiny adapter that only the lands-related logic ever consumed: scene-manager (hasLandLease), the list-scene-admins handler (getAuthorizations), and roomMetadataSync (lease-hol... Pull #261 LautaroPetaccio github
85.26
25226958604 refactor/room-metadata-sync test: cover undefined-authorizations defensive guard in getLeaseHoldersForParcels Pull #261 LautaroPetaccio github
85.42
25226858307 refactor/room-metadata-sync refactor: lands adapter as a wkc component, owns lease-holders lookup splits src/adapters/lands.ts into the standard wkc layout under src/adapters/lands/ (component.ts, types.ts, errors.ts, index.ts) and moves LandPermissionsNotFoundError + the L... Pull #261 LautaroPetaccio github
85.38
25225789460 refactor/room-metadata-sync refactor: tighten sceneId typing and guard scene-room parsing addresses two type-safety review comments: - GetRoomNameParams.sceneId is now `sceneId?: string`, matching the runtime: getRoomName already handles a missing sceneId (legacy world ... Pull #261 LautaroPetaccio github
85.44
25224471412 refactor/room-metadata-sync refactor: use @dcl/memory-cache-component for the webhook refresh cooldown replaces the local Map<string, number> + manual prune helper inside roomMetadataSync with an injected ICacheStorageComponent. the cache entry's existence is the cooldown s... Pull #261 LautaroPetaccio github
85.42
25223686457 refactor/room-metadata-sync refactor: extract room metadata sync and add scene admins to metadata room metadata exposed only banned addresses; clients also need the set of effective admins to render admin badges and pre-validate admin actions before hitting the gatekeeper. ... Pull #261 LautaroPetaccio github
85.42
See All Builds (757)

Badge your Repo: comms-gatekeeper

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh