decentraland / comms-gatekeeper
86%

DEFAULT BRANCH: main
Repo Added
Token H9CF0YzviAGXBYzx8ZZY8Lv8V4wtqKxTm regen
Build 874 Last
Files 151
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 85.967% (+0.3%) from 85.683%
32380477054

push

github

web-flow 
fix(auth): upgrade @dcl/crypto-middleware to 6 (#289)

* fix(auth): upgrade @dcl/crypto-middleware to 6

Version 6 binds the metadata bytes into the signed payload instead of
lowercasing them, so the signature now covers the metadata exactly as
delivered rather than only its case-folded form.

No source changes are needed. The middleware already handed handlers the
metadata as the client sent it, cased, both before and after this change;
only the payload the signature is checked against differs. Every
metadata.signer comparison and every value read out of authMetadata keeps
behaving as it did.

The test helper does need to catch up: getAuthHeaders signed the previous
payload format, so without this every integration auth test would fail
against a correctly working service.

Note that clients must ship the new signing format before this deploys.
Any explorer still signing the previous payload gets a 401, and that is
every scene-originated request rather than a subset, because the metadata
this service reads is camelCase throughout (sceneId, realmName,
realm.serverName, deviceIdentifier).

* test(auth): expect the signature rejection rather than the removed guard

The watcher-token spec covering a scene signer signed canonically and
delivered re-cased asserted a 400 from the canonical-value guard that
@dcl/crypto-middleware 5.1.0 applied. Version 6 joins the metadata bytes
into the signed payload, so the delivered bytes no longer reproduce what
was signed and the request fails verification first, with a 401.

The behaviour under test is unchanged: the request is still refused and
the handler is still not reached. Only the layer that refuses it moved,
from a guard covering two named fields to the signature covering all of
them.

* refactor(auth): use the shared signer predicates from crypto-middleware 6.1

The five hand-rolled metadataValidator closures are replaced by
requireSigner and rejectIfSigner. Same gates, expressed once in the
library rather tha... (continued)

1145 of 1456 branches covered (78.64%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

3137 of 3525 relevant lines covered (88.99%)

78.61 hits per line

Relevant lines Covered
3525 RELEVANT LINES 3137 COVERED LINES
78.61 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32380477054 main fix(auth): upgrade @dcl/crypto-middleware to 6 (#289) * fix(auth): upgrade @dcl/crypto-middleware to 6 Version 6 binds the metadata bytes into the signed payload instead of lowercasing them, so the signature now covers the metadata exactly as de... push web-flow github
85.97
32374157099 fix/crypto-middleware-6 test(auth): cover the legacy fallback through the middleware path too The scene-adapter routes verify through validate()/oldValidate(); every other route goes through the middleware instances. Those are two separate opt-ins, and the spec only exe... Pull #289 LautaroPetaccio github
85.97
32314105557 fix/crypto-middleware-6 feat(auth): accept the legacy payload on explorer-facing routes Upgrading to crypto-middleware 6 breaks every explorer client: unity, godot and bevy all still sign the pre-6.0.0 payload, and the metadata they send is camelCase throughout, so fold... Pull #289 LautaroPetaccio github
85.97
32186114728 fix/crypto-middleware-6 refactor(auth): use the shared signer predicates from crypto-middleware 6.1 The five hand-rolled metadataValidator closures are replaced by requireSigner and rejectIfSigner. Same gates, expressed once in the library rather than repeated per route... Pull #289 LautaroPetaccio github
85.66
32174690553 fix/crypto-middleware-6 test(auth): expect the signature rejection rather than the removed guard The watcher-token spec covering a scene signer signed canonically and delivered re-cased asserted a 400 from the canonical-value guard that @dcl/crypto-middleware 5.1.0 appl... Pull #289 LautaroPetaccio github
85.68
31608223803 fix/scene-base-integrity perf: cache active world scene lookups Pull #285 LautaroPetaccio github
85.65
31599212132 fix/reliable-community-voice-chat-ended-event fix: publish the ended event for every expired community voice chat The expiration sweep resolved each room's participant count from `getAllActiveCommunityVoiceChats`, but that query only returns rooms that still have an active moderator — which ... Pull #288 LautaroPetaccio github
85.79
31554999125 fix/scene-base-integrity fix: resolve active world scene before token issuance Pull #285 LautaroPetaccio github
85.56
31535246478 fix/scene-base-integrity Merge origin/main into fix/scene-base-integrity Pull #285 LautaroPetaccio github
85.44
31203221036 2.29.1 fix(auth): upgrade crypto middleware validation (#287) push GitHub github
85.68
See All Builds (871)

Badge your Repo: comms-gatekeeper

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh