decentraland / comms-gatekeeper / 34887569144

87%

main: 86%

Build Type

Pull #283

github

Committed by LautaroPetaccio

Commit Message

refactor: move the ban-result cache into the access gate and extract the keyed queue

Cluster subscriber ban path. The subscriber asked the connection store for
the wallet's last device before calling the access gate, which user
moderation already does when no device id is supplied, and kept its own
30 s LRU of results. Both are gone: it now calls the gate by address with
the new `cached` option and drops the playerConnectionDb dependency. A
failing connection-store read now falls through to an address-only ban
match inside user moderation instead of failing open.

Access gate. Gains an opt-in result cache, a dedicated
@dcl/memory-cache-component instance (`accessGateCache`) keyed by address
and device id, with its TTL from ACCESS_GATE_CACHE_TTL_MS (renamed from
CLUSTER_BAN_CACHE_TTL_MS; the definitions repo sets neither). A result
produced by a swallowed ban-lookup failure is never kept. Callers that do
not opt in, the two token handlers, keep querying every time.

Keyed queue. The subscriber's per-wallet promise chain and the LiveKit
adapter's per-room metadata lock were the same mechanism. It is now
src/adapters/keyed-queue, with one instance per consumer
(`clusterWalletQueue`, `roomMetadataQueue`) and its own spec for the
ordering, isolation and cleanup guarantees.

Pull Request Pull Request #283: feat: mint LiveKit island rooms from Pulse cluster feed (Archipelago ⇒ Pulse, iteration 1)

Coverage Stats

1261 of 1571 branches covered (80.27%)

Branch coverage included in aggregate %.

320 of 323 new or added lines in 17 files covered. (99.07%)

4 existing lines in 2 files now uncovered.

3441 of 3832 relevant lines covered (89.8%)

82.27 hits per line