decentraland / comms-gatekeeper / 34879214649

87%

main: 87%

Build Type

Pull #283

github

Committed by LautaroPetaccio

Commit Message

refactor: resolve holdsParticipant with a single listParticipants call

listRooms was there so a missing room read as an empty array instead of
an error code. It cost a second round trip on the common path, where the
island room still exists, and opened a race: a room closed between the
two calls made listParticipants reject with not_found, holdsParticipant
rejected with it, and the subscriber read that as "cannot tell" and left
the peer stranded for another reconnect.

Now one call. A not_found rejection is absence, whether the room never
existed or has just closed. Any other rejection still propagates, so the
reconnect gate keeps failing closed on a LiveKit outage.

Pull Request Pull Request #283: feat: mint LiveKit island rooms from Pulse cluster feed (Archipelago ⇒ Pulse, iteration 1)

Coverage Stats

1257 of 1566 branches covered (80.27%)

Branch coverage included in aggregate %.

302 of 304 new or added lines in 15 files covered. (99.34%)

2 existing lines in 1 file now uncovered.

3437 of 3826 relevant lines covered (89.83%)

82.27 hits per line