decentraland / comms-gatekeeper
85%

DEFAULT BRANCH: main
Repo Added
Token H9CF0YzviAGXBYzx8ZZY8Lv8V4wtqKxTm regen
Build 828 Last
Files 151
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x
Sync Branches

coverage: 85.372% (+0.03%) from 85.347%
28616085146

push

github

web-flow 
fix: address security audit findings (access control, disclosure, hardening) (#276)

* fix: address security audit findings across access control and hardening

Resolves the findings from a full-codebase security review.

Access control (HIGH):
- Bind LiveKit streaming-key issuance and scene-ban checks to the sceneId that
  forms the room, not a separately-supplied parcel. Previously the admin/ban
  check ran against a place resolved from an unvalidated parcel while the
  room/key was derived from sceneId, allowing cross-scene stream injection and
  a scene-ban bypass via mismatched parcel/sceneId.
- generate-stream-link resolves a world-name-as-sceneId to the real content
  hash so the room and place stay consistent (mirrors comms-scene-handler).
- Require signed-fetch auth on /cast/watcher-token and enforce scene bans on the
  viewer, so a banned user can't rejoin a scene's comms room as a watcher.

Disclosure & secrets (MEDIUM):
- /users/:address/bans (unauthenticated) now returns only user-facing fields
  (isBanned, expiresAt, customMessage), not moderator identity, device id, or
  reason.
- Stop logging the ingress streamKey / ingest URL.
- Remove the committed COMMS_GATEKEEPER_AUTH_TOKEN default from .env.default so
  requireString fails fast; tests get a fixture value via jest setup.
- Add encodeURIComponent to user-influenced URL segments in places/worlds/social.

Robustness & hardening (LOW):
- Close a duplicate-active-ban race with a transaction-scoped advisory lock.
- Add a non-unique partial index on scene_stream_access(ingress_id) (dropped
  with the old unique constraint); guard streaming writes against empty ingress_id.
- Lowercase address in the private voice-chat status lookup.
- Dedup + ON CONFLICT in createVoiceChatRoom; bound bulk community_ids (maxItems).
- Overlap guard on the streaming-key TTL cron; deactivate empty-ingress expired
  rows by place in the streaming TTL cron.
- Protect land-lease holders from scene bans; return 40... (continued)

1121 of 1436 branches covered (78.06%)

Branch coverage included in aggregate %.

85 of 94 new or added lines in 21 files covered. (90.43%)

4 existing lines in 1 file now uncovered.

3081 of 3486 relevant lines covered (88.38%)

75.03 hits per line

Relevant lines Covered
3486 RELEVANT LINES 3081 COVERED LINES
75.03 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28616085146 main fix: address security audit findings (access control, disclosure, hardening) (#276) * fix: address security audit findings across access control and hardening Resolves the findings from a full-codebase security review. Access control (HIGH): - ... push web-flow github
85.37
28373235419 main fix: preserve stored IP/device on null upsert of player connection info (#275) * fix: preserve stored IP/device on null upsert of player connection info The player_connection_info upsert overwrote ip_address and device_id unconditionally on conf... push web-flow github
85.35
28303785699 main feat: record player IP/device on token requests and support device bans (#274) * feat: record player IP/device on token requests and support device/IP bans Capture each player's latest IP (Cloudflare cf-connecting-ip header) and device id (devic... push web-flow github
85.35
28047204770 main fix: cancel undrained undici response bodies to prevent socket/memory leaks (#272) Since the move to native fetch (undici, via @dcl/traced-fetch-component), a Response whose body is never read keeps its pooled socket checked out and its bytes buf... push web-flow github
85.25
28047179576 main chore: bump @dcl/http-server and @dcl/traced-fetch-component for upstream fixes (#273) - @dcl/http-server 2.0.2 -> 2.1.0: request-hot-path perf (parse URL once, CORS no-Origin passthrough, O(L) router chain) and the new fromNativeResponse helpe... push web-flow github
85.25
28041467667 main fix: suppress comms events for preview realms regardless of ALLOW_LOCAL_PREVIEW (#271) The participant joined/left webhook handlers skipped publishing UserJoinedRoom/UserLeftRoom events for local preview realms via livekit.isLocalPreview(). That ... push web-flow github
85.25
27975617693 main feat: bump @dcl/crypto-middleware to 4.1.0 (#270) update @dcl/crypto-middleware from ^4.0.0 to ^4.1.0 to pick up the latest published release. push web-flow github
85.24
27974006364 main refactor: replace remaining well-known-components with @dcl equivalents (#269) replace @well-known-components/http-requests-logger-component with @dcl/http-requests-logger-component and @well-known-components/test-helpers with @dcl/test-helpers, ... push web-flow github
85.24
27959049160 main fix: generate valid LiveKit tokens after permission changes (#268) push web-flow github
85.24
27946542432 main fix: ignore stale participant_left after community voice rejoin (#267) push web-flow github
85.25
See All Builds (825)

Badge your Repo: comms-gatekeeper

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh