ruby-grape / grape

97%

master: 97%

LAST BUILD ON BRANCH refactor/rescue-handler-dedup

branch: refactor/rescue-handler-dedup

CHANGE BRANCH

x

Reset

• refactor/rescue-handler-dedup
• DateFormat
• Handle_json_array
• ISSUE-2321
• Issue-1908
• active_support_6_1_minimal
• add-agents-md
• add_irb_in_gemfile_for_bundle_console_warning
• add_rack_3_2_gemfile
• add_rails_8_1_on_ci
• add_ruby_3_4
• add_ruby_4_0_cli
• api_override_singleton_methods
• benchmark/results-machine-spec
• body-metadata
• bugfix/1577
• bugfix/1970
• bugfix/1986
• bugfix/2041
• bugfix/autoload
• bugfix/memory-leak
• build_with_registry
• chore/agents-md-style-rules
• chore/cleanup-on-compilation
• chore/coercion-tests
• chore/drop-middleware-globals
• chore/guard-clause-cleanup
• chore/json-parse-fallback
• chore/min-ruby-3.3
• chore/normalize-eql-aliases
• chore/primitive-coercer-spec
• chore/prune-requires
• chore/raise-dependency-lower-bounds
• chore/readability-guard-clauses
• chore/readability-pass
• clean_up_useless_dependencies
• cleanup-deprecated-code
• compiled_endpoints
• contract_scope_validator_public_schema
• cookies_delegation
• crush_desclared_params
• custom-validator-namespace-lookup
• declared_params_optional_array
• deprecated_endpoint_return
• doc
• doc/remove_manual_toc_and_toc_danger_check
• doc/remove_toc
• doc/update_reload_documentation_for_current_Rails_versions
• docs/readme-typos-and-fixnum-cleanup
• draft/middleware-options-data
• drop_ruby_3_0_as_7_0
• drop_support_ruby_2_7_0
• dynamic_registration
• empty_string_and_bool
• enable_branch_coverage
• enable_frozen_string_literal_ci
• endpoint_cleanup
• entity-dsl
• erik/remove-faulty-documentation-about-blank-values
• exclude_ruby_3_2_rails_edge
• exposes-to-s
• extract_entity_dsl_and_kwargs_with
• extract_testing_module
• extract_translation
• failing_spec_for_1967
• faster_normalize_path
• feature/endpoint-logger
• feature/error-formatter-kwargs-2527
• feature/grape-api-setup-var-array
• feature/hash-oneof-2385
• feature/return_of_return
• feature/warn-on-helper-overrides
• feature_rack_lint
• fix-636
• fix-badges
• fix-before-each-nil-nomethoderror
• fix-docs
• fix-helper-inheritance
• fix-typo
• fix/2748-structured-message-leak
• fix/2763-multijson-deprecations
• fix/auth-base-subclass-issue-2669
• fix/avoid_multiple_mounts_pollution
• fix/cascade_reading_api_level
• fix/custom-type-coercer-symbolize-collection
• fix/json-load-create-additions
• fix/json-use-parse
• fix/multixml-deprecation
• fix/reduce_base_route_array_allocation
• fix/rescue-from-internal-errors-2482
• fix/sendfile_test_fix
• fix/variant-collection-coercer-to-s
• fix_2566_memory_leak
• fix_all_media_types_regression
• fix_before_each_no_method_error
• fix_coercer_cache
• fix_danger_workflow
• fix_endpoint_status_when_not_calling_error!
• fix_gh_workflow_annotations_warnings
• fix_helpers_methods_in_public_scope
• fix_leaky_slash
• fix_middleware_keywords
• fix_param_scope_thread_safety
• fix_registry_warning_message
• fix_require_logger
• fix_routes_memoization
• fix_shared_params_empty_args
• fix_style_optional_boolean_parameter
• format_header_best_q_match
• funding
• happy_rubocop
• hook-readme
• instance_to_s_delegation
• issue-1775
• issue-2385
• lazy_block
• lazy_compile
• less_active_support_concern
• less_parse_nested_query
• master
• migrate-danger-pr-comment
• migrate-to-dry-configurable
• mountable_apis
• namespace_route_param_explicit_kwargs
• optimize/parameters-extract-options-non-mutating
• optimize_api_documentation
• patch-1
• perf/avoid-empty-hash-merges
• perf/build-headers-each-header
• perf/instrument-only-when-subscribed
• perf/lazy-base-inheritable-new-values
• perf/lazy-inheritable-setting-fields
• perf/lazy-param-scope-tracker
• perf/lazy-response-cookies
• perf/precompute-middleware-caches
• perf/request-hot-path-polish
• perf/router-transaction-no-proc
• perf/routing-args-in-place-merge
• perf/skip-empty-validation-errors-alloc
• perf/skip-redundant-routing-args-write
• perf/skip-validation-backtrace
• perf/stackable-empty-singleton
• perf/versioner-path-prefix
• private_namespace_reverse_stackable_with_hash
• private_within_namespace
• rack_request_error
• real-api-integration-test
• reduce_array_alloc_on_setup
• refactor/api-instance-dsl-modules
• refactor/attrs_iterator
• refactor/auth-dsl-kwargs
• refactor/available-media-types-attr-reader
• refactor/base-validator-encapsulation
• refactor/coerce-options-data
• refactor/de-morgan-conditions
• refactor/declared-params-handler
• refactor/declared_availability
• refactor/define-method-cleanup
• refactor/drop-indifferent-and-reverse-merge-requires
• refactor/dsl-group-validators-dry
• refactor/endpoint-options-data
• refactor/endpoint-options-route-enabled
• refactor/error-response-data
• refactor/error-response-value-object
• refactor/extract-handler-case-when
• refactor/extract-path-normalizer
• refactor/guard-clauses-style
• refactor/inline-mustermann-grape
• refactor/lazy-base-ancestor
• refactor/middleware-cleanups
• refactor/named_kwargs_params_scope
• refactor/params-dsl-using-except-kwargs
• refactor/precomputed-content-types-move
• refactor/replace-tap-usages
• refactor/rescue-from-explicit-first-arg
• refactor/router-pattern-delegation
• refactor/router-simplification
• refactor/shared-options-data
• refactor/stateless-attributes-iterator
• refactor/validates-pure-helpers
• refactor/validation-errors-drop-enumerable
• refactor/validations-spec-self-validate
• refactor/version-guard-clause
• refactor_available_media_types_in_header_middleware
• refactor_declared_params_handling
• refactor_http_headers
• refactor_mime_type_for
• refactor_route_setting_internal_usage
• refactor_setting_get_or_set
• refs/heads/master
• refs/tags/v1.7.1
• refs/tags/v1.8.0
• refs/tags/v2.0.0
• release/3.2.1
• remove-unused-constant
• remove_deprecated_param_builder_extensions
• remove_guard
• remove_instance_variable_defined
• remove_namespace_reverse_stackable_from_public_interface
• remove_namespace_stackable_and_inheritable_from_public_space
• remove_namespace_stackable_with_hash_from_public_interface
• remove_non_supported_jsonapi
• remove_obsolete_docker_compose_version
• remove_path_dup
• remove_settings_unset_functions
• remove_strict_hash_configuration
• remove_test_prof
• replace_try_by_respond_to
• rescue_from
• resolve_performace_issue_with_given
• revert-1953-chore/micto-optimization-3
• revert-2726-refactor/stateless-attributes-iterator
• revert-wrong-commit
• revisit_auth_middleware
• revisit_endpoint_helpers_and_new
• revisit_middleware_default_options
• revisit_validators
• ruby3_handling_argument_delegation
• ruby_3_1_shorthand_kwargs
• ruby_optimizations
• ruby_style_send
• skip_instrumentation_no_validators
• skip_run_filters_on_empty
• small_refactor_versioner_middleware
• spec-only-rack-class
• test/grape-swagger-integration
• try_pattern_instead_of_respond_to
• update_min_ruby_version_and_rubocop
• update_return_upgrading_notes_and_simplify_execute
• update_rubocop
• update_rubocop_1_71_2
• update_rubocop_1_88
• update_rubocop_and_autocorrect
• upgrade-mustermann
• upgrade-rubocop
• upgrading-description
• use_forwardable
• use_require_relative_in_gemspec
• v0.19.2
• v1.0.0
• v1.0.1
• v1.0.2
• v1.0.3
• v1.1.0
• v1.2.0
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.5
• v1.3.0
• v1.3.1
• v1.3.2
• v1.3.3
• v1.4.0
• v1.5.0
• v1.5.1
• v2.1.0
• v2.1.1
• v2.1.2
• v2.1.3
• v2.2.0
• v2.3.0
• v2.4.0
• v3.0.0
• v3.0.1
• v3.1.0
• v3.1.1
• v3.2.0
• v3.2.1
• v3.3.0
• valid_encoding_before_scrubing
• validators_bad_encoding

Build # 24694315106

Build Type

Pull #2688

github

Committed by ericproulx

Commit Message

Consolidate rescue handler lookup in Middleware::Error

`rescue_handler_for_base_only_class` and `rescue_handler_for_class_or_its_ancestor`
were structurally identical — same option-hash lookup, same fallback to
`default_rescue_handler`. Only the option key and match predicate differed:
`:base_only_rescue_handlers` + `klass == err` for `rescue_from FooError,
rescue_subclasses: false`, versus `:rescue_handlers` + `klass <= err` for the
default exact-or-ancestor form.

Collapse both into `registered_rescue_handler`, which encapsulates the DSL
concept (any handler the user registered via `rescue_from`) and preserves
exact-before-ancestor precedence. A shared `rescue_handler_from(key, &matcher)`
primitive holds the lookup scaffolding once.

`find_handler` now reads as a priority list of four named concepts: user-
registered handler, Grape exception, catch-all, or re-raise. The exact/ancestor
precedence moves one level down, properly encapsulated inside
`registered_rescue_handler`.

No public API change; behavior is identical.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2688: Consolidate rescue handler lookup in Middleware::Error

Coverage Stats

1069 of 1153 branches covered (92.71%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

3351 of 3404 relevant lines covered (98.44%)

32231.3 hits per line