ruby-grape / grape
100%
master: 100%

LAST BUILD BRANCH: fix/negotiated-format-fallback
DEFAULT BRANCH: master
Repo Added
Files 166
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/fold-attributes-iterators
branch: refactor/fold-attributes-iterators
CHANGE BRANCH
x

coverage: 100.0%. Remained the same
36247543738

Pull #3009

github

ericproulx 
Fold the attribute iterator subclasses into AttributesIterator

SingleAttributeIterator and MultipleAttributesIterator differed only in
the private yield_attributes hook: one yielded each element, the other
yielded it once per attribute along with its emptiness. The block a
validator passes to #each can already hold that difference, so
AttributesIterator now yields each element, skipping the empty optional
placeholder as both did, and the validators that want the attribute
loop write it in their block.

- Base#validate! loops over @attrs itself and asks empty_element?,
  which SingleAttributeIterator#empty? duplicated. The emptiness and
  dependency checks only read the element, so they now run once per
  element instead of once per attribute.
- DefaultValidator#validate! calls apply_defaults for each element, the
  code its direct path already ran.
- The iterator no longer takes attrs, and the iterator_class hook goes.

On two request shapes that go through the iterator, an Array nested in
an Array is 6-9% faster (3-4% under YJIT) and a given scope 16-18%
(29-33% under YJIT).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Pull Request #3009: Fold the attribute iterator subclasses into AttributesIterator

1494 of 1494 branches covered (100.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 3 files covered. (100.0%)

4314 of 4314 relevant lines covered (100.0%)

29201.53 hits per line

Relevant lines Covered
4314 RELEVANT LINES 4314 COVERED LINES
29201.53 HITS PER LINE
Source Files on refactor/fold-attributes-iterators

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
36247543738 refactor/fold-attributes-iterators Fold the attribute iterator subclasses into AttributesIterator SingleAttributeIterator and MultipleAttributesIterator differed only in the private yield_attributes hook: one yielded each element, the other yielded it once per attribute along with... Pull #3009 ericproulx github
100.0
36247529931 refactor/fold-attributes-iterators Fold the attribute iterator subclasses into AttributesIterator SingleAttributeIterator and MultipleAttributesIterator differed only in the private yield_attributes hook: one yielded each element, the other yielded it once per attribute along with... push ericproulx github
100.0
See All Builds (4202)