ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/build-headers-each-header
DEFAULT BRANCH: master
Repo Added
Files 167
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/error-response-value-object
branch: refactor/error-response-value-object
CHANGE BRANCH
x

coverage: 96.935% (-0.02%) from 96.955%
25361964135

Pull #2693

github

ericproulx 
Introduce Grape::Exceptions::ErrorResponse value object

`Middleware::Error#error_response` previously handled three input shapes
polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base`
subclass, and an arbitrary user-handler return. Hash-style access like
`error[:status]` only worked on exceptions because `Grape::Exceptions::Base#[]`
delegated to `__send__` — a "pretend to be a Hash" trick that propped up the
polymorphism in `error_response`.

Introduce `Grape::Exceptions::ErrorResponse`, a small value object with
`status`, `message`, `headers`, `backtrace`, and `original_exception` readers
plus a `coerce(input)` classifier that normalizes Hash, Exception, and
ErrorResponse inputs into a uniform value at the boundary. The middleware now
calls `coerce` once at entry and reads typed attributes — no more polymorphism
puzzle in the body.

Migrated the seven internal `throw :error, hash` sites to throw `ErrorResponse`
instances. User-defined `throw :error, hash` from custom middleware or
`rescue_from` blocks continues to work via `coerce`.

`Grape::Exceptions::Base#[]` is preserved (still delegates to `__send__`) and
covered by new specs. The only contract change is that the `throw :error`
payload is now an `ErrorResponse` value object instead of a `Hash` — see
UPGRADING for migration notes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2693: Introduce Grape::Exceptions::ErrorResponse value object

1080 of 1165 branches covered (92.7%)

Branch coverage included in aggregate %.

48 of 50 new or added lines in 6 files covered. (96.0%)

3411 of 3468 relevant lines covered (98.36%)

32144.89 hits per line

Relevant lines Covered
3468 RELEVANT LINES 3411 COVERED LINES
32144.89 HITS PER LINE
Source Files on refactor/error-response-value-object

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25361964135 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.94
25361617949 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.93
25361551546 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
25235318615 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
25215069391 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
25088463308 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
24755543065 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
24755531894 refactor/error-response-value-object Introduce Grape::Exceptions::ErrorResponse value object `Middleware::Error#error_response` previously handled three input shapes polymorphically: a Hash from `throw :error, {...}`, a `Grape::Exceptions::Base` subclass, and an arbitrary user-handl... Pull #2693 ericproulx github
96.95
See All Builds (3142)