ruby-grape / grape
100%
master: 100%

LAST BUILD BRANCH: fix/content-type-order-cache
DEFAULT BRANCH: master
Repo Added
Files 171
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/cyclomatic-complexity
branch: refactor/cyclomatic-complexity
CHANGE BRANCH
x

coverage: 99.95% (-0.02%) from 99.966%
39049735756

Pull #3036

github

ericproulx 
Hold every method to RuboCop's default cyclomatic complexity

Metrics/CyclomaticComplexity was raised to 15; the 31 methods above the
default of 7 are split instead, each into the helper or predicate its
own comments already described, and the override is dropped.

Behaviour is unchanged. A few of the splits also simplify:

- Router: #transaction hands what it tries after a decline or a miss to
  #fall_back, and the route scan it shares with the static table is one
  #matched_route. #neighbours drops two `!cascaded` tests a nil
  neighbour already answers.
- `redirect` picks its message from the status it set.
- The `type == 'Set'` test in DeclaredParamsHandler is dropped, since
  `start_with?('Set')` already answers it.
- The `values:` / `except_values:` checks share one #fixed_values?.

Request-path fast paths stay inline: PathNormalizer's early returns, the
router's static and bucket lookups, #match? / #greedy_match?, and the
`represent` lookup an error message goes through. Two specs pin what
mutation testing showed unpinned among the moved lines: an ANY route
closing the cascading sibling it supersedes, and `allow_blank` not
counting `false` as blank.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull Request #3036: Hold every method to RuboCop's default cyclomatic complexity

1501 of 1503 branches covered (99.87%)

Branch coverage included in aggregate %.

177 of 177 new or added lines in 22 files covered. (100.0%)

4465 of 4466 relevant lines covered (99.98%)

29391.51 hits per line

Relevant lines Covered
4466 RELEVANT LINES 4465 COVERED LINES
29391.51 HITS PER LINE
Source Files on refactor/cyclomatic-complexity

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
39049735756 refactor/cyclomatic-complexity Hold every method to RuboCop's default cyclomatic complexity Metrics/CyclomaticComplexity was raised to 15; the 31 methods above the default of 7 are split instead, each into the helper or predicate its own comments already described, and the ove... Pull #3036 ericproulx github
99.95
39049696879 refactor/cyclomatic-complexity Hold every method to RuboCop's default cyclomatic complexity Metrics/CyclomaticComplexity was raised to 15; the 31 methods above the default of 7 are split instead, each into the helper or predicate its own comments already described, and the ove... push ericproulx github
99.95
See All Builds (4340)