ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/default-status-single-read
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/version-capture-regexp
branch: perf/version-capture-regexp
CHANGE BRANCH
x

coverage: 96.953% (+0.005%) from 96.948%
33768125512

Pull #2889

github

ericproulx 
Read the path version off the route the router already matched

Under path versioning the version is a named capture in every route pattern —
`Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it
is constrained to the declared versions. So by the time a request reaches the
endpoint's middleware stack, the router has already sliced the segment out of
the path, validated it, and left it in `env['grape.routing_args'][:version]`.

`Versioner::Path#before` derived it a second time, from scratch:

    path_info = Grape::Util::PathNormalizer.call(env[Rack::PATH_INFO])
    return if path_info == '/'
    @prefixes.each { |prefix| path_info = path_info.delete_prefix(prefix) if ... }
    slash_position = path_info.index('/', 1)
    return version_from_first_segment(path_info, slash_position) if slash_position

— a normalize, a prefix strip and a slice, for an answer already in the env.

Read it from there instead. The path parse stays, and answers three cases the
routing args cannot:

* no routing args at all, when the middleware runs outside a Grape router;
* the greedy routes behind auto-OPTIONS and 405, which capture nothing;
* a route that declares a `:version` segment of its own on top of the
  versioning one, where Mustermann reports the capture as every position it
  matched rather than the single segment recorded here — hence the
  `is_a?(String)` guard.

`Router#call` now also publishes the path it routed on as
`env['grape.normalized_path']`, so that fallback does not normalize `PATH_INFO`
a second time either. It is the same string the router matched against, which
is what the versioner wants to agree with.

This leans on the version capture being strict, so it comes after
"Constrain the version capture with a Regexp instead of an Array" — before it,
a percent-encoded segment matched the route and Mustermann decoded it, and the
versioner would have accepted what it used to reject.

Median of 5 interleaved runs against master (R... (continued)
Pull Request #2889: Constrain the version capture with a Regexp instead of an Array

1244 of 1338 branches covered (92.97%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 4 files covered. (100.0%)

3943 of 4012 relevant lines covered (98.28%)

27013.42 hits per line

Relevant lines Covered
4012 RELEVANT LINES 3943 COVERED LINES
27013.42 HITS PER LINE
Source Files on perf/version-capture-regexp

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33768125512 perf/version-capture-regexp Read the path version off the route the router already matched Under path versioning the version is a named capture in every route pattern — `Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it is constrained to the decl... Pull #2889 ericproulx github
96.95
33759907081 perf/version-capture-regexp Read the path version off the route the router already matched Under path versioning the version is a named capture in every route pattern — `Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it is constrained to the decl... Pull #2889 ericproulx github
96.95
33758582524 perf/version-capture-regexp Constrain the version capture with a Regexp instead of an Array `Pattern#extract_capture` hands the declared versions to Mustermann as the Array of Strings they arrive in: requirements.merge(version: map_str(version)) Mustermann uses `captu... Pull #2889 ericproulx github
96.95
33758398003 perf/version-capture-regexp Constrain the version capture with a Regexp instead of an Array `Pattern#extract_capture` hands the declared versions to Mustermann as the Array of Strings they arrive in: requirements.merge(version: map_str(version)) Mustermann uses `captu... Pull #2889 ericproulx github
96.95
33755546064 perf/version-capture-regexp Read the path version off the route the router already matched (#2890) Under path versioning the version is a named capture in every route pattern — `Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it is constrained to ... Pull #2889 ericproulx github
96.95
33728877091 perf/version-capture-regexp Read the path version off the route the router already matched (#2890) Under path versioning the version is a named capture in every route pattern — `Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it is constrained to ... Pull #2889 ericproulx github
96.97
33728112169 perf/version-capture-regexp Read the path version off the route the router already matched (#2890) Under path versioning the version is a named capture in every route pattern — `Pattern::Path#build_parts` inserts `:version` ahead of the namespace — and it is constrained to ... Pull #2889 web-flow github
96.97
33727233129 perf/version-capture-regexp Constrain the version capture with a Regexp instead of an Array `Pattern#extract_capture` hands the declared versions to Mustermann as the Array of Strings they arrive in: requirements.merge(version: map_str(version)) Mustermann uses `captu... Pull #2889 ericproulx github
96.96
33686809238 perf/version-capture-regexp Constrain the version capture with a Regexp instead of an Array `Pattern#extract_capture` hands the declared versions to Mustermann as the Array of Strings they arrive in: requirements.merge(version: map_str(version)) Mustermann uses `captu... Pull #2889 ericproulx github
96.94
33686629872 perf/version-capture-regexp Constrain the version capture with a Regexp instead of an Array `Pattern#extract_capture` hands the declared versions to Mustermann as the Array of Strings they arrive in: requirements.merge(version: map_str(version)) Mustermann uses `captu... push ericproulx github
96.94
See All Builds (3693)