ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/default-status-single-read
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/lazy-params-builder
branch: perf/lazy-params-builder
CHANGE BRANCH
x

coverage: 96.954% (+0.001%) from 96.953%
33768948857

Pull #2892

github

ericproulx 
Resolve the params builder when params are first read, not in the constructor

`Grape::Request#initialize` runs once per request, and resolved the params
builder eagerly:

    def initialize(env, build_params_with: nil)
      super(env)
      @params_builder = Grape::ParamsBuilder.params_builder_for(build_params_with || Grape.config[:param_builder])
    end

Two lookups behind that line, both on the request path:

* `Grape.config[:param_builder]` — dry-configurable's `Config#[]`, 126 ns;
* `params_builder_for` — a `key?` plus a `[]` against the registry
  `HashWithIndifferentAccess`, 200 ns together.

`@params_builder` has exactly one reader, `make_params`, which only runs when
something asks for `params`. An endpoint with no validations whose block never
mentions them — a health check, a static resource, a redirect — paid both
lookups to build an object it then dropped.

Memoize it on first use instead. `Grape.config` stays the source of truth, read
at the same point in the request as before for anything that does read params,
so a `build_with :unknown` still surfaces as a 500 during the request rather
than at mount time.

Median of 5 interleaved runs against master (Ruby 4.0.5): **+5.9%** on a
minimal versioned GET that never touches params; **+1.1%** on one with params
and validations, where the work moved rather than disappeared.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2892: Resolve the params builder when params are first read, not in the constructor

1244 of 1338 branches covered (92.97%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3945 of 4014 relevant lines covered (98.28%)

26995.9 hits per line

Relevant lines Covered
4014 RELEVANT LINES 3945 COVERED LINES
26995.9 HITS PER LINE
Source Files on perf/lazy-params-builder

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33768948857 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... Pull #2892 ericproulx github
96.95
33759973410 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... Pull #2892 ericproulx github
96.95
33728750519 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... Pull #2892 ericproulx github
96.97
33727241665 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... Pull #2892 ericproulx github
96.97
33686818750 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... Pull #2892 ericproulx github
96.94
33686636094 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... push ericproulx github
96.94
33686453279 perf/lazy-params-builder Resolve the params builder when params are first read, not in the constructor `Grape::Request#initialize` runs once per request, and resolved the params builder eagerly: def initialize(env, build_params_with: nil) super(env) @par... push ericproulx github
96.94
See All Builds (3693)