ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/default-status-single-read
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/formatter-skip-rack-request
branch: perf/formatter-skip-rack-request
CHANGE BRANCH
x

coverage: 96.954% (-0.02%) from 96.973%
33607648930

Pull #2881

github

ericproulx 
Decide whether a request has a body before building a Rack::Request

`Formatter#read_body_input` opened with

    input = rack_request.body # reads RACK_INPUT
    return if input.nil?
    return unless read_body_input?

so every request built a `Rack::Request` to reach `rack.input`, and then
`read_body_input?` returned false for anything that is not a POST, PUT, PATCH
or DELETE. On the GET, HEAD and OPTIONS majority the object was constructed,
asked for one env key, and discarded.

`read_body_input?` opened with four `Rack::Request` predicates —
`post? || put? || patch? || delete?` — each of which is a comparison against
`env['REQUEST_METHOD']`. Reading that key directly answers the same question
without the object, and it is the first thing the method needs to know.

Test the method off the env, and fetch the input only once the answer is yes.
A body-carrying request builds the `Rack::Request` exactly as before, for the
`form_data?` / `parseable_data?` / `content_length` checks that genuinely need
it; everything else never touches one.

Counted over 20 GETs, the formatter's copy is gone: 20 objects of the
`Rack::Request` family are created rather than 40, the survivor being the
`Grape::Request` the endpoint builds for itself.

End to end that is 166,376 -> 168,173 req/s on a bare JSON GET (+1.1%) and
257,731 -> 261,704 on a static route (+1.5%) — median of 9 runs interleaved
with master's, Ruby 4.0.5 with YJIT — with one fewer object per request.

The reordering is behaviour-preserving. Nothing between the two guards depends
on the input having been read, and `read_body_input?` consults only the request
method, the content type and the content length — never the body.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2881: Decide whether a request has a body before building a Rack::Request

1236 of 1330 branches covered (92.93%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3921 of 3989 relevant lines covered (98.3%)

27215.79 hits per line

Relevant lines Covered
3989 RELEVANT LINES 3921 COVERED LINES
27215.79 HITS PER LINE
Source Files on perf/formatter-skip-rack-request

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33607648930 perf/formatter-skip-rack-request Decide whether a request has a body before building a Rack::Request `Formatter#read_body_input` opened with input = rack_request.body # reads RACK_INPUT return if input.nil? return unless read_body_input? so every request built a `R... Pull #2881 ericproulx github
96.95
33557906942 perf/formatter-skip-rack-request Decide whether a request has a body before building a Rack::Request `Formatter#read_body_input` opened with input = rack_request.body # reads RACK_INPUT return if input.nil? return unless read_body_input? so every request built a `R... Pull #2881 ericproulx github
96.93
33557842949 perf/formatter-skip-rack-request Decide whether a request has a body before building a Rack::Request `Formatter#read_body_input` opened with input = rack_request.body # reads RACK_INPUT return if input.nil? return unless read_body_input? so every request built a `R... push ericproulx github
96.93
33557865119 perf/formatter-skip-rack-request Merge 162cab463 into 19d1668a4 Pull #2881 web-flow github
96.93
See All Builds (3659)