ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/default-status-single-read
DEFAULT BRANCH: master
Repo Added
Files 169
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/avoid-empty-hash-merges
branch: perf/avoid-empty-hash-merges
CHANGE BRANCH
x

coverage: 96.998% (+0.004%) from 96.994%
24754486154

Pull #2689

github

ericproulx 
Avoid empty-hash merges on request hot paths

Three `|| {}` patterns on the per-request path allocated an empty Hash
and handed it to a merge that produced a shallow copy of the left-hand
side — pure waste. Guard the merge when the right-hand side is absent
or empty instead.

When a route has no path placeholders (or none captured), `route.params`
returns an empty Hash (or nil). The old code did
`args.merge(route_params || {})`, allocating `{}` and then a new hash
identical to `args` on every matched static route.

`grape_routing_args` falls back to `{}` when env has no routing args.
`deep_merge!` on `{}` is a walking no-op. Skip the call entirely when
routing_args is empty.

`(body || {}).merge(key => representation)` — when no body is set
(the common case), this allocated `{}` only to merge one key into it.
Build the one-key hash directly.

process_route, no route_params (static path, common case):
  old: 4.48 M i/s, 480 objects allocated / 1k calls
  new: 8.31 M i/s, 160 objects allocated / 1k calls  (1.85x faster, 3x fewer)

process_route, empty {} route_params:
  old: 5.16 M i/s, 320 objects / 1k calls
  new: 8.02 M i/s, 160 objects / 1k calls  (1.55x faster, 2x fewer)

process_route, real route_params: within noise (unchanged path).

No behavior change; all 2,236 specs pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2689: Avoid empty-hash merges on request hot paths

1077 of 1161 branches covered (92.76%)

Branch coverage included in aggregate %.

3350 of 3403 relevant lines covered (98.44%)

32233.81 hits per line

Relevant lines Covered
3403 RELEVANT LINES 3350 COVERED LINES
32233.81 HITS PER LINE
Source Files on perf/avoid-empty-hash-merges

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24754486154 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
97.0
24695684488 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695575162 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695534936 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695445811 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695398154 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695337163 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
24695325552 perf/avoid-empty-hash-merges Avoid empty-hash merges on request hot paths Three `|| {}` patterns on the per-request path allocated an empty Hash and handed it to a merge that produced a shallow copy of the left-hand side — pure waste. Guard the merge when the right-hand side... Pull #2689 ericproulx github
96.94
See All Builds (3693)