ruby-grape / grape / 34029068515

97%

master: 99%

Pull #2908

github

Stop reassigning method parameters across lib

A parameter reassigned partway through a method means the name documents
one thing in the signature and holds another below it. Every site in
`lib` now binds the derived value to its own local, so a parameter keeps
what the caller passed for the whole method.

Two of them were reassigned to hide a mutation of the argument itself,
and those stop writing into what they were given:

* `Middleware::Formatter#ensure_content_type` merged a Content-Type into
  the response headers Hash in place, then returned it.
* `ParamsScope#process_oneof!` wrote the collected variants back into the
  options Hash from the `requires`/`optional` call site. Now
  `#collected_oneof` returns them and the caller merges.

`Endpoint::Options` is left alone; it is fixed in #2907.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1245 of 1334 branches covered (93.33%)

Branch coverage included in aggregate %.

74 of 75 new or added lines in 16 files covered. (98.67%)

3950 of 4013 relevant lines covered (98.43%)

27098.72 hits per line