ruby-grape / grape
99%
master: 100%

LAST BUILD BRANCH: fix/translated-format-spec-order
DEFAULT BRANCH: master
Repo Added
Files 177
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH chore/require-ruby-3-3-1
branch: chore/require-ruby-3-3-1
CHANGE BRANCH
x

coverage: 99.037%. Remained the same
35462725465

Pull #2966

github

ericproulx 
Require Ruby 3.3.1

Ruby 3.3.0 rejects forwarding an anonymous parameter from inside a block:

    def compose_message(key, **)
      MESSAGE_STEPS.filter_map { |step, _| translate_message(:"#{key}.#{step}", **) }
    end
    # 3.3.0: anonymous keyword rest parameter is also used within block (SyntaxError)

Its forwarding_arg_check moved up to the enclosing scope before looking for
an anonymous parameter, so it found the method's own `**` and reported a
conflict for any block. 3.3.1 fixed it (ruby 2a84aaf4a8, backporting
596db9c1f4, [Feature #19370] "Blocks without anonymous parameters should
not affect"); only a block that declares an anonymous parameter of its own
is rejected now, on every version.

lib/grape/exceptions/base.rb has done this since 3.2.0, and Grape loads
every file up front, so no release since has loaded on Ruby 3.3.0 while
the gemspec allowed it. CI's 3.3 job runs the latest 3.3.x, which is why
nothing flagged it.

required_ruby_version is now '>= 3.3.1'. With that floor, the remaining
named arguments that were only forwarded are forwarded anonymously, and
RuboCop skips tmp/.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Pull Request #2966: Require Ruby 3.3.1

1451 of 1507 branches covered (96.28%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 3 files covered. (100.0%)

4307 of 4307 relevant lines covered (100.0%)

28762.85 hits per line

Relevant lines Covered
4307 RELEVANT LINES 4307 COVERED LINES
28762.85 HITS PER LINE
Source Files on chore/require-ruby-3-3-1

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
35462725465 chore/require-ruby-3-3-1 Require Ruby 3.3.1 Ruby 3.3.0 rejects forwarding an anonymous parameter from inside a block: def compose_message(key, **) MESSAGE_STEPS.filter_map { |step, _| translate_message(:"#{key}.#{step}", **) } end # 3.3.0: anonymous ke... Pull #2966 ericproulx github
99.04
35462715753 chore/require-ruby-3-3-1 Require Ruby 3.3.1 Ruby 3.3.0 rejects forwarding an anonymous parameter from inside a block: def compose_message(key, **) MESSAGE_STEPS.filter_map { |step, _| translate_message(:"#{key}.#{step}", **) } end # 3.3.0: anonymous ke... push ericproulx github
99.04
See All Builds (4407)