iotaledger / iota

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(iota-json-rpc,iota-core,iota-sdk)!: remove the JSON-RPC WebSocket server and subscriptions (#13339)

# Description of change

Removes the deprecated JSON-RPC subscriptions `iotax_subscribeEvent` and
`iotax_subscribeTransaction`, and with them the JSON-RPC WebSocket
endpoint that was only needed for them. Use `iotax_queryEvents` and
`iotax_queryTransactionBlocks`, GraphQL subscriptions, or gRPC
checkpoint streaming instead.

- **Node:** removes `iotax_subscribeEvent` and
`iotax_subscribeTransaction`, the WebSocket routes and handler, and the
subscription handler and streamer that matched every executed
transaction against all subscribers. The JSON-RPC server always serves
HTTP.
- **Config:** removes the `jsonrpc-server-type` and
`indexer-max-subscriptions` node settings. Existing configs that set
them still load; the settings are ignored.
- **Execution:** full nodes no longer convert the effects and events of
every executed transaction into JSON-RPC types for subscribers; the two
metrics that counted this are removed.
- **Rust SDK and CLI:** removes the WebSocket client (`ws_url`,
`ws_ping_interval`, `IotaClient::ws`, `available_subscriptions`),
`subscribe_event`, `subscribe_transaction`, the `ws` entry of `IotaEnv`
and the `--ws` option of `iota client new-env`. A `ws` entry in an
existing `client.yaml` is ignored.
- **Code only the subscriptions used:** the `Filter` implementations of
`EventFilter`, `TransactionFilter` and `TransactionFilterV2` and
`EffectsWithInput` are removed; the `Filter` trait moves into
`iota-graphql-rpc`, its only user. Subscription support leaves the
OpenRPC generator, and jsonrpsee is built without its WebSocket and wasm
clients.
- **JSON-RPC logger and metrics:** the transport protocol is removed
from the logger, together with the `on_connect`, `on_response` and
`on_disconnect` hooks the server never called and the four metrics only
they updated (`rpc_client`, `rpc_inflight_connection`,
`rpc_request_size`, `rpc_respons... (continued)

Coverage Stats

18 of 32 new or added lines in 8 files covered. (56.25%)

515 existing lines in 43 files now uncovered.

197396 of 274825 relevant lines covered (71.83%)

458142.6 hits per line