iotaledger / iota / 39704840957

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(iota-core,iota-e2e-tests): save post-consensus validation decisions and repeat them when a commit is replayed (#13129)

# Description of change

- Stacked on #13110.
- With the flag on, the consensus handler saves its keep or drop
decision for every user transaction of a commit before scheduling them,
and a commit replayed after a restart repeats those decisions instead of
deciding again from state that has moved on.
- A saved drop is repeated without checks. A saved keep that has
executed is kept from its effects; one that has not is validated again
through the commit-indexed reader.
- A commit's decisions are deleted in the batch that makes its output
durable, so they stay as long as the commit can be replayed. Those of a
commit whose output never flushes, such as one abandoned at the switch
to synced checkpoints, stay until the epoch ends.
- The decision is saved as a data-free enum with a stable encoding, and
the error of a drop as separate BCS bytes. A binary that cannot decode a
saved error still repeats the drop, with `IotaError::Unknown` in its
place.
- A drop because an input is not visible at the horizon yet is saved as
`DroppedInputNotVisibleYet` and is not the digest's final status: the
transaction can be kept when it is sequenced again. A status request
after such a drop waits for the retry instead of returning the old
error.
- A retry of a dropped transaction reaches validation at every commit it
appears in, because the handler's processed-transaction cache holds only
keys recorded as processed (`consensus_dedup_only_recorded_messages`,
#13169), which deterministic validation requires (#13106). This PR adds
tests for that, not a handler change. Once a transaction is kept, a
later copy is skipped as already processed.
- Testnet and Mainnet are unaffected: everything here is behind
`pcool_deterministic_validation`, which no protocol version enables and
which requires `enable_pcool_flow`, run only on devnet-style chains. The
epoch tabl... (continued)

Coverage Stats

319 of 326 new or added lines in 5 files covered. (97.85%)

1391 existing lines in 47 files now uncovered.

192281 of 270368 relevant lines covered (71.12%)

459967.93 hits per line