iotaledger / iota / 40432264074
72%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1129
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.691% (+0.1%) from 71.573%
40432264074

push

github

web-flow 
chore(iota-core): test a Move authenticator account named as shared but not shared on chain (#13178)

# Description of change

Test a Move authenticator whose account is named as a shared object but
is immutable or address-owned on chain.

- With P-COOL on, post-consensus validation drops the transaction, takes
no locks, and reports the account error that names the account:
`ImmutableAccountObjectNotSupported` for an immutable account,
`AccountObjectNotSupported` for an owned one.
- The drop is what keeps such a transaction from execution. There, the
check of the authenticator inputs rejects the account with
`NotSharedObject` before any effects are written, and the execution
driver halts on that error. If the account check ever leaves
post-consensus validation, these tests fail instead.
- No execution-path test: it would only pin that halting error.
- On the validation path, `check_move_account` runs before the
shared-input check, so its immutable-account branch is reached with the
shared reference too, not only with the immutable-or-owned one. That
branch and the `ImmutableAccountObjectNotSupported` mapping in
`check_move_account_for_execution` stay for protocol versions before 36.

## Links to any relevant issues

Fixes #13146

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`cargo test -p iota-core --lib post_consensus_validation_tests`: 34
passed, including the two new tests.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

197591 of 275613 relevant lines covered (71.69%)

445196.7 hits per line

Coverage Regressions

Lines Coverage ∆ File
348
87.09
0.13% crates/iota-core/src/authority.rs
119
53.37
53.37% crates/iota-indexer/src/historical_fallback/client.rs
107
0.0
0.0% crates/iota-indexer/src/historical_fallback/reader.rs
101
52.56
-1.76% iota-execution/latest/iota-adapter/src/execution_mode.rs
52
67.09
0.08% crates/iota-graphql-rpc/src/config.rs
49
92.51
0.21% crates/iota-json-rpc/src/governance_api.rs
41
77.38
11.28% crates/iota-json-rpc/src/authority_state.rs
30
94.09
0.03% iota-execution/latest/iota-adapter/src/programmable_transactions/execution.rs
27
69.07
-0.36% crates/iota-indexer/src/config.rs
27
92.23
-0.05% crates/iota-protocol-config/src/lib.rs
25
88.58
0.43% crates/iota-grpc-server/src/metrics.rs
25
35.42
0.0% crates/iota-indexer/src/errors.rs
24
58.53
2.12% crates/iota-json-rpc-types/src/iota_object.rs
22
73.05
4.35% crates/iota-json-rpc/src/indexer_api.rs
20
74.85
0.0% crates/iota-json-rpc/src/lib.rs
18
0.0
0.0% crates/iota-graphql-rpc/src/context_data/db_data_provider.rs
17
92.91
0.73% crates/iota-open-rpc-macros/src/lib.rs
15
96.38
0.06% crates/iota-metrics/src/lib.rs
14
90.25
0.72% crates/iota-core/src/transaction_orchestrator.rs
13
0.0
0.0% crates/iota-indexer/src/indexer.rs
12
82.43
0.96% crates/iota-sdk/src/wallet_context.rs
10
44.16
-12.99% crates/iota-types/src/messages_grpc.rs
10
79.4
-0.27% crates/test-cluster/src/lib.rs
8
74.0
-8.0% crates/iota-vm-sdk/src/executor/types.rs
7
93.16
-3.68% crates/iota-core/src/transaction_driver/mod.rs
7
50.0
0.0% crates/iota-grpc-server/src/constants.rs
7
70.79
-1.16% crates/iota-transaction-builder/src/lib.rs
6
63.96
0.48% crates/iota-json-rpc-types/src/iota_transaction.rs
6
67.32
-3.92% crates/iota-json-rpc-types/src/lib.rs
6
50.5
-5.94% crates/iota-json-rpc-types/src/object_changes.rs
6
70.7
-0.25% crates/iota/src/client_commands.rs
6
74.68
-2.58% crates/iota-types/src/iota_system_state/mod.rs
5
55.77
-9.62% crates/iota-json-rpc-types/src/iota_coin.rs
5
89.23
0.98% crates/iota-test-transaction-builder/src/lib.rs
4
94.12
0.06% crates/iota-grpc-server/src/server.rs
4
52.04
-1.36% crates/iota-sdk/src/apis/read.rs
4
96.13
-0.1% crates/starfish/core/src/authority_service.rs
3
71.35
-0.27% crates/iota-core/src/authority/authority_store.rs
3
82.14
0.0% crates/iota-genesis-builder/src/validator_info.rs
3
81.76
2.32% crates/iota-sdk/src/lib.rs
3
66.67
-33.33% crates/iota-types/src/clock.rs
3
88.77
-1.05% crates/iota-types/src/effects/mod.rs
3
56.81
2.11% crates/iota-types/src/storage/shared_in_memory_store.rs
2
89.35
-0.69% crates/iota-core/src/connection_monitor.rs
2
93.45
-0.31% crates/iota-core/src/transaction_driver/effects_certifier.rs
2
82.84
-0.1% crates/iota-grpc-server/src/event_filter.rs
2
86.15
0.77% crates/iota-grpc-server/src/transaction_filter.rs
2
92.83
-0.18% crates/iota-network/src/state_sync/mod.rs
2
99.28
0.0% iota-execution/latest/iota-move-natives/src/tx_context.rs
1
71.23
-0.17% crates/iota-core/src/authority_server/validator.rs
1
84.12
-0.06% crates/iota-core/src/jsonrpc_index.rs
1
30.12
-1.2% crates/iota-json-rpc/src/logger.rs
1
98.18
0.0% crates/starfish/config/src/committee.rs
1
95.6
-0.05% crates/starfish/core/src/commit_syncer/fast.rs
1
94.37
-0.03% crates/starfish/core/src/header_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 40432264074.1 1129
71.69
GitHub Action Run
Source Files on build 40432264074