iotaledger / iota / 39883454019

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(iota-core,iota-types): label a committed user transaction as shared or owned without merging its shared inputs (#13246)

# Description of change

- Stacked on #13245.
- With the P-COOL flow, the consensus handler labels every committed
transaction as shared or owned for its metrics before validating it. For
a `UserTransactionV1` it merged the shared objects of the transaction
and of its Move authenticators, and that merge panics when two
declarations of one object disagree. Only `validity_check`, which runs
later, rejects such a transaction.
- The label now checks the transaction's own shared inputs and each Move
authenticator's shared objects separately, without merging them. The
answer is the same as before for every transaction, so the metric labels
do not change, and validation drops the transaction.
- `shared_input_objects()` is unchanged: its other callers run after
validation.
- Testnet and Mainnet are unaffected: committed `UserTransactionV1`
transactions exist only with `enable_pcool_flow`, run only on
devnet-style chains. This fix applies there with or without
`pcool_deterministic_validation`.
- Commits:
- `fix(iota-core): label a committed user transaction as shared or owned
without merging its shared inputs`
- `test(iota-core, iota-types): check that a committed user transaction
whose shared object declarations disagree is dropped`

## Links to any relevant issues

None.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

New tests commit such a transaction and check that the consensus handler
drops it, with and without deterministic validation.

~~~shell
cargo ci-clippy
IOTA_SKIP_SIMTESTS=1 cargo nextest run -p iota-core --lib -E
'test(/consensus_ha... (continued)

Coverage Stats

79 of 79 new or added lines in 2 files covered. (100.0%)

4746 existing lines in 100 files now uncovered.

195017 of 273269 relevant lines covered (71.36%)

458151.16 hits per line