iotaledger / iota / 40612933562

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(iota-node): load the migration data only until the genesis checkpoint is executed (#13350)

# Description of change

- A node whose genesis contains migration transactions loaded
`migration.blob` on every startup: it read and validated the whole file
and re-executed every migration transaction to rebuild its objects, even
though the data is only needed until the genesis checkpoint has been
executed.
- The node now loads the migration data only when the database is empty
or the genesis checkpoint has not been executed yet (no highest executed
checkpoint recorded). The executor records that watermark only after the
checkpoint's transaction outputs are on disk, so once it is set all
migration transactions are executed and stored.
- Once the genesis checkpoint has been executed, the owner index no
longer receives the migration objects at startup. Index creation is
being reworked separately, so this case is not handled here.

## Links to any relevant issues

None.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

No existing test starts a node from a genesis with migration data; a
restart against a testnet or mainnet database is still needed to confirm
the faster startup.

### Release Notes

- [ ] Protocol:
- [x] Nodes (Validators and Full nodes): Nodes no longer load and
re-execute the migration data (`migration.blob`) on startup once the
genesis checkpoint has been executed.
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] gRPC:

<!-- Do not remove: everything below this line is ignored by the
release-notes check. -->

---

Coverage Stats

6 of 7 new or added lines in 1 file covered. (85.71%)

535 existing lines in 38 files now uncovered.

197677 of 275634 relevant lines covered (71.72%)

449660.7 hits per line