hyperledger / fabric-x-common

82%

main: 82%

LAST BUILD ON BRANCH issue-231-checktxid

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• add-system-tx-status
• agents-init
• allow_OUs
• arma_known_certs_support
• asn1-message-to-sign
• asn1-unmarshal
• batch-block-hash
• blk-itr-ctx
• blkstorage/skip-unused-tx-index-info
• bump-fabric-lib-go
• bump-go-1.27.3-vulns
• copilot/fix-data-race-logger
• coveralls
• cryptogen-org-folder-domain
• cryptogen-recreate
• cryptogen/arma-adoption
• defer-signature-verification
• dep-cheap-cleanup
• dep-drop-gorilla
• dependabot/go_modules/go_modules-9c5197dcb8
• dependabot/go_modules/go_modules-a135cde889
• dependabot/go_modules/go_modules-c93f3641e6
• doc-stale-meta-namespace-key
• expose-ledger-api
• fabric-lib-go-v1.1.3
• feat/add_string_render_msp_policy
• feat/add_user_admin_creation_in_cryptogen
• fix-acl
• fix-block-verification-policy-orderer
• fix-data-hash
• fix-fileledger-newest-empty
• fix-flaky-bft-deliverer-tests
• fix-gpl
• follow_compare_blocks_by_header_and_data
• fxadmin_cli_skeleton
• fxadmin_cli_skeleton_fix_review_comments
• fxadmin_compute_update_command
• fxadmin_decode_command
• fxadmin_follow_command
• fxadmin_follow_returns_the_config_block
• fxadmin_improve
• fxadmin_ledger_command_address_comments
• fxadmin_ledger_commands
• fxadmin_modify_app_add
• fxadmin_modify_party_node
• fxadmin_require_enough_resp_in_submit
• fxadmin_set_tx_id_in_env
• fxadmin_tx_command_merge_and_endorse
• fxadmin_tx_command_prepare
• fxadmin_tx_command_send
• fxadmin_tx_command_submit
• go-1.27
• grpc-logger
• guide-for-configtx.md
• hash-tls-cert
• hold-halt
• hotfix/allow_cryptogen_custom_admin_users
• hyphen-key
• idemix-update
• issue-231-checktxid
• json_manipulation_automation_skeleton
• load-config-material
• main
• move-serve-connection-retry
• msp-factory-idemix-versions
• new-status
• no-capabilities-usage
• notify-header
• notify-include-metadata
• notify-new-api
• operation_endpoints
• ordererpb_Extract_the_common_Arma_node_fields_into_a_NodeConfig_message
• oreder_shared_config_ext
• protoutil-envelope-signature-header
• quick-asn1-marshal
• remove-non-maintained-pkg
• remove-spew
• remove-tx-status-batch
• rename-all-tx
• replace-govaluate
• return-not-found-blk-store
• rm-para-config-block
• routerAsmSignCert
• sampleconfig-committer-acls
• sidecar-notify-reject
• smartbft-migrate
• snapshot-abort
• snapshot-checkpoint-hash
• snapshot-checkpoint-policy
• snapshot-proto
• snapshot-reject-status
• testcrypto-auth-peer
• testcrypto-prepare-block-in-place
• tx-metadata
• tx-metadata-fix
• unify-sidecar-service
• unique-genesis-default
• update-dependencies-4
• verifier-test

Build # 40230048789

Build Type

Pull #232

github

Committed by tock-ibm

Commit Message

[protoutil] Avoid allocations and the echoed TxID in CheckTxID

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- `ComputeTxID` and `CheckTxID` hash and hex-encode into stack buffers. `ComputeTxID` keeps its signature, and the returned string is its only allocation. `CheckTxID` no longer allocates.
- `CheckTxID` rejects a TxID that isn't `2*sha256.Size` characters long before hashing.
- On mismatch, `CheckTxID` returns the new sentinel `protoutil.ErrInvalidTxID` ("invalid txid"). The error no longer includes the received or expected TxID, so callers that matched on the old message should use `errors.Is` instead.
- `proputils.go` now uses `github.com/cockroachdb/errors` instead of `github.com/pkg/errors`.

#### Additional details (Optional)

Benchmarks added in `proputils_test.go`, with a 24-byte nonce and a 1,000-byte creator (before → after):

| case | before | after |
|---|---|---|
| `ComputeTxID` | 2,990 ns, 160 B, 3 allocs | 2,880 ns, 64 B, 1 alloc |
| `CheckTxID`, valid TxID | 3,040 ns, 160 B, 3 allocs | 2,830 ns, 0 B, 0 allocs |
| `CheckTxID`, wrong TxID, 64 chars | 3,950 ns, 672 B, 9 allocs | 2,830 ns, 0 B, 0 allocs |
| `CheckTxID`, wrong TxID, 1 MB | 744 µs, 2.1 MB, 12 allocs | 2.8 ns, 0 B, 0 allocs |

#### Related issues

- resolves #231

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Yoav Tock <TOCK@il.ibm.com>

Pull Request Pull Request #232: [protoutil] Avoid allocations and the echoed TxID in CheckTxID

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

13837 of 16834 relevant lines covered (82.2%)

0.82 hits per line