hyperledger / fabric-x-common / 39793857722

82%

main: 82%

Build Type

Pull #228

github

Committed by tock-ibm

Commit Message

[blocksprovider] Fix BFT censorship monitor stop race and flaky deliverer test

#### Type of change

- Bug fix
- Test update

#### Description

- `BFTCensorshipMonitor.launchHeaderReceivers()` does nothing once the monitor is stopped, so `Monitor()` can no longer start header receivers that are never stopped.
- The BFT deliverer test fake now ends each deliver stream only when its own connection context is cancelled, like gRPC. Previously, all streams shared one fake whose `CloseSend` pushed an error onto the shared response channel, so a late-closing old stream could fail the stream that replaced it. The `CloseSendStub = nil` workarounds in `TestBFTDeliverer_BlockReception` are no longer needed and are removed.

#### Additional details (Optional)

Ran both tests 150 times each with `-race -cpu 1,2,4` and no failures. Before the fix, the same run reproduced the #155 panic; #128 did not reproduce locally, so its fix rests on the CI log.

#### Related issues

- resolves #128
- resolves #155

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #228: [blocksprovider] Fix BFT censorship monitor stop race and flaky deliverer test

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

13830 of 16838 relevant lines covered (82.14%)

0.82 hits per line