hyperledger / fabric-x-common / 39773948939

82%

Build Type

push

github

Committed by web-flow

Commit Message

[configtxlator] Replace gorilla/mux and gorilla/handlers (#226)

#### Type of change

- Dependency update

#### Description

- The REST router is an `http.ServeMux` with method+path patterns, and
handlers read the message name with `r.PathValue`.
- CORS is handled by `github.com/rs/cors` with the same options: the
configured origins, `POST` only, and `Content-Type`.

#### Additional details (Optional)

- gorilla's `StrictSlash(true)` redirected a trailing-slash path
(`/protolator/decode/common.Block/`) to the path without it. Such a path
now returns 404.
- rs/cors answers every preflight with 204 and refuses one by leaving
out the CORS headers, where gorilla used 400/403/405. Browsers see the
same outcome.

#### Related issues

- resolves #221
- address #219

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

5 existing lines in 3 files now uncovered.

13828 of 16835 relevant lines covered (82.14%)

0.82 hits per line