hyperledger / fabric-x-committer
91%
main: 90%

LAST BUILD BRANCH: queue-gauge-depgraph
DEFAULT BRANCH: main
Repo Added
Files 133
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH queue-gauge-depgraph
branch: SELECT
CHANGE BRANCH
x

coverage: 90.531% (+0.2%) from 90.345%
34088332371

Pull #810

github

liran-funaro 
[coordinator] Report the dependency graph queue sizes on scrape

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Replace the dependency graph manager's ticker-based queue monitor with gauges read on scrape, and
  delete the sampler goroutine.
- Gather the two input queues into a receive-only `managerQueues` struct built before the metrics
  that observe them.
- Rename `gdgWaitingTxQueueSize` and `dependentTransactionsQueueSize` to `gdgWaitingTxCount` and
  `dependentTxCount`, since neither is a queue: both count transactions held in the graph's maps and
  stay maintained incrementally.
- Rename the exported `coordinator_dependency_graph_dependent_transactions_queue_size` to
  `coordinator_dependency_graph_dependent_transactions`, for the same reason.
- Reword `coordinator_global_dependency_graph_size`'s help to lead with what it counts.
- Remove the `queue-monitor-sampling-time` config key, whose only reader was the sampler.

#### Additional details (Optional)

Deployed YAML that still sets `queue-monitor-sampling-time` keeps loading, as `v.Unmarshal` ignores
unknown keys.

Dashboard-breaking: `coordinator_dependency_graph_dependent_transactions_queue_size` becomes
`coordinator_dependency_graph_dependent_transactions`. `coordinator_global_dependency_graph_size`
keeps its name, as it never claimed to be a queue.

One of the per-service PRs split out of #736.

#### Related issues

- resolves #771
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
Pull Request #810: [coordinator] Report the dependency graph queue sizes on scrape

29 of 29 new or added lines in 5 files covered. (100.0%)

10 existing lines in 6 files now uncovered.

9312 of 10286 relevant lines covered (90.53%)

11242.18 hits per line

Relevant lines Covered
10286 RELEVANT LINES 9312 COVERED LINES
11242.18 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34088332371 queue-gauge-depgraph [coordinator] Report the dependency graph queue sizes on scrape #### Type of change - Improvement (improvement to code, performance, etc) #### Description - Replace the dependency graph manager's ticker-based queue monitor with gauges read on ... Pull #810 liran-funaro github
90.53
34088216121 queue-gauge-depgraph [coordinator] Report the dependency graph queue sizes on scrape #### Type of change - Improvement (improvement to code, performance, etc) #### Description - Replace the dependency graph manager's ticker-based queue monitor with gauges read on ... Pull #810 liran-funaro github
90.3
34088148506 queue-gauge-depgraph [coordinator] Report the dependency graph queue sizes on scrape #### Type of change - Improvement (improvement to code, performance, etc) #### Description - Replace the dependency graph manager's ticker-based queue monitor with gauges read on ... Pull #810 liran-funaro github
90.49
33762901489 main [docker] Initialize the database when the test node starts it (#807) #### Type of change - Bug fix #### Description * Change the test-node `run` script to perform a database initialization whenever a caller starts the database with the `db` op... push web-flow github
90.34
33759475367 queue-gauge-depgraph [coordinator] Report the dependency graph queue sizes on scrape #### Type of change - Improvement (improvement to code, performance, etc) #### Description - Replace the dependency graph manager's ticker-based queue monitor with gauges read on ... Pull #810 liran-funaro github
90.53
33752741694 main Bump google.golang.org/grpc from 1.82.1 to 1.83.1 in the go_modules group across 1 directory (#809) Bumps the go_modules group with 1 update in the / directory: [google.golang.org/grpc](https://github.com/grpc/grpc-go). Updates `google.golang.or... push web-flow github
90.5
33750177294 dependabot/go_modules/go_modules-4d54e058aa Bump google.golang.org/grpc in the go_modules group across 1 directory Bumps the go_modules group with 1 update in the / directory: [google.golang.org/grpc](https://github.com/grpc/grpc-go). Updates `google.golang.org/grpc` from 1.82.1 to 1.83.... Pull #809 web-flow github
90.51
33737353773 queue-gauge-notifier-stream [sidecar] Report each notification stream's block queue #### Type of change - New feature #### Description - Report each `StreamAllTransactions` subscription's block queue as `sidecar_notifier_stream_block_queue_size`, one series per live st... Pull #744 liran-funaro github
90.42
33737351482 queue-gauge-per-stream [verifier] Report the per-stream executor queues #### Type of change - New feature #### Description - Add `monitoring.ChannelLenGaugeVec[T]`, a collector for a queue that exists once per stream or worker. `Register`/`Unregister` add and remo... Pull #737 liran-funaro github
90.61
33736639523 queue-gauge-notifier-stream [sidecar] Report each notification stream's block queue #### Type of change - New feature #### Description - Report each `StreamAllTransactions` subscription's block queue as `sidecar_notifier_stream_block_queue_size`, one series per live st... Pull #744 liran-funaro github
90.66
See All Builds (1120)