hyperledger / fabric-x-committer / 39786451575

91%

main: 91%

Build Type

Pull #836

github

Committed by liran-funaro

Commit Message

[loadgen] Replace the per-signature ECDSA DRBG with a random nonce

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- `ecdsaSigner` derives its own nonce from `crypto/ecdh`'s `GenerateKey` instead of calling
  `crypto/ecdsa.SignASN1`.
- It encodes the signature's DER with `cryptobyte`, into a builder preallocated to the
  curve's largest possible signature.
- `newEcdsaSigner` fails on P-224 keys, which `crypto/ecdh` does not support.
- `TestFastEcdsaSignerIsVerifiable` verifies the new signer's output with
  `ecdsa.VerifyASN1`, and `BenchmarkEcdsaSigners` measures it against the standard library's
  signer.
- `golang.org/x/crypto` moves from an indirect to a direct dependency, at the same version,
  because `cryptobyte` lives there.
- `NewNsEndorserFromKey` returns its errors directly, dropping its unused `err` variable and
  bare `err` return.

#### Related issues

- resolves #812
- related to #798

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #836: [loadgen] Replace the per-signature ECDSA DRBG with a random nonce

Coverage Stats

47 of 63 new or added lines in 2 files covered. (74.6%)

4 existing lines in 2 files now uncovered.

9802 of 10830 relevant lines covered (90.51%)

11222.35 hits per line