hyperledger / fabric-x-committer

91%

main: 91%

LAST BUILD ON BRANCH vc-manager-tracker-key

branch: vc-manager-tracker-key

CHANGE BRANCH

x

Reset

• vc-manager-tracker-key
• add-live-connection-monitoring
• additional-db-test
• admin-db-init
• apt-ci-fix
• auto-merge-fix
• backoff-v5
• bccsp-race
• bench-report-metrics
• bft-delivery
• bft-metrics
• bob-reduce-context
• bob-rules
• buffer-race
• build-unify
• channel-race
• ci-gotestsum
• cli-refactor
• cli-refs
• client-test-race
• client-tls-bug
• commit-config-immediately
• config-docs-yaml
• configurable-coordinator-parameters
• configurable-retry-sig-vc-managers
• connection-test-dep
• coord-queue-deadlock
• coordinator-docs
• coordinator-manager-metrics
• coordinator-manager-parity
• coordinator-metadata-fix
• coordinator-test-no-db
• coordinator-vc-api-split
• coveralls
• create-multiple-namespaces-test
• create-new-sys-ns
• cryptogen-recreate-support
• dedup-templ
• default-test-node-startup-setup
• default-viper
• deliver-check-block-order
• deliver-seek-tls-cert
• deliver-seek-tls-cert-fix
• deliverorderer-tests
• delivery-data-blocks
• dependabot/go_modules/go_modules-9c5197dcb8
• dependabot/go_modules/go_modules-d35c03d4db
• dependabot/go_modules/go_modules-dc1255629f
• dependabot/go_modules/go_modules-eee72e131a
• dependencygraph-race
• deployment-strategy
• doc-loadgen-artifacts
• docker-moby-update
• dynamic-root-ca
• dynamic-tls
• enable-pprof
• expose-ledger-api
• external-server-config
• extract-prometheus-startup-and-grpc-server-start
• fabric-lib-go-v1.1.3
• fabric-logging
• fix-automatic-env
• fix-bft-detection
• fix-connection-reset
• fix-container-image
• fix-container-test-macos
• fix-db-test
• fix-falky-svmupdate-test
• fix-flaky
• fix-flaky-conn-metrics
• fix-flaky-loadgen-coord
• fix-master-tserver-rf
• fix-metrics
• fix-mkdoc-url
• fix-port-container-test
• fix-release-path
• fix-sign
• fix-test-node-with-insecure
• fix-test-wait
• fix-waiting-tx-count
• fix/690-notifier-metric-assertions
• fix/696-integration-port-reservation
• fix/712-grpcretry-port-reservation
• fix/coordinator-waiting-status-count
• fix/todo-001
• fix/todo-002
• fix/todo-005
• fix/todo-017
• flaky-coordinator-test-615
• flaky-test-orderer
• getpeersmspdirs-no-hardcode
• go-fix
• grpc-logger-fix
• grpcservice-refactor
• healthz-check
• http-endpoint
• inline-commands
• iss-640
• keep-alive-parameters-testing
• ledger-service-wait-behaviour
• lifecycle-policy
• limit-block-apis
• limit-inputs-block-apis
• llm-adjust
• load-config-block-certs
• loadgen-config-cleanup
• loadgen-const-distribution-shorthand
• loadgen-index-addressable-keys
• loadgen-manual-msp
• loadgen-probability-validation
• loadgen-remove-ctx
• loadgen-remove-query
• main
• make-ci-local
• make-fixes
• makefile-lints
• makefile-test-flags
• metrics-bob-rules
• metrics-tls
• metrics-url-race
• migrate-to-postgres-official-image
• minimize-logs
• mkdocs
• mock-orderer-direct-config
• mock-orderer-dynamic-tls
• mock-orderer-features
• mock-orderer-stream-holder
• mock-verifier-race
• move-retry-package
• move-testcrypto-to-common
• namespace-policy-docs
• notifier-metrics
• notify-full-block
• notify-tx-metadata
• optimize-map-block
• orderer-config-race
• pgx5
• postgres-renaming
• prom-refactor
• publish-common-packages
• qs-pen-test-fix
• race-detection
• rate-limit-sidecar
• refactor-channel
• refactor-cmd
• refactor-test
• release-1.0
• remove-common-root-cas
• remove-file
• remove-ifrit-gomega
• remove-loadgen-distribution
• remove-non-maintained-pkg
• rename
• rename-materials
• rename-util-files
• retry-infinite-max-elapsed-time
• review-ai-prompt
• rm-gpl-tools
• rm-reployment
• rm-unused
• root-ca-workaround-fix
• service-manager
• sidecar-block-store-code-fix
• sidecar-diagram-mod
• sidecar-diagrm
• sidecar-limit-active-txids-notifier
• sidecar-process-snapshot-checkpoint
• sidecar-race
• sidecar-receiver-unwrap-envelope-lite
• sidecar-remove-chan-id
• sidecar-unified
• skill-commit
• skill-dev
• skills-fork-pr-workflow
• skills-omit-verification-from-pr-body
• snapshot-creation
• snapshot-hash
• snapshot-reject-if-inprogress
• split-tablets
• start-server-readiness-context
• sustain-config
• sync-block
• template-tls-per-endpoint
• test-container-port-binding
• test-coverage-connection
• test-coverage-improve
• test-coverage-latency
• test-coverage-tests
• test-limiter-max-wait
• test-minor-fixes
• test-query-status
• test-tls-flatten
• testcrypto-race
• testcrypto-refactor
• tls-docs-update
• tx-metadata
• unused-code
• update-common
• update-common-dep
• update-dep
• update-dep-4
• update-depenencies-3
• update-deps
• update-dev-skills
• update-to-latest-common
• update-to-yugabytedb-latest-lts
• upgrade-common-dep
• upgrade-pg
• utils-channel-optional-writer
• vc-docs
• vc-race
• vc-resource-leak
• verifier-snapshot-checkpoint
• verifier-test-remove-gomega
• verifier-timeout
• viper-default-annot
• worktree-notification-docs

Build # 30354642771

Build Type

Pull #710

github

Committed by liran-funaro

Commit Message

[coordinator] Fix VC manager in-flight transaction tracking

#### Type of change

- Bug fix
- Test update

#### Description

- Return the transactions to `txBeingValidated` when forwarding their results fails, so that
  `recoverPendingTransactions` can re-queue them instead of dropping them. The signature verifier
  manager already guards this invariant, the VC manager did not.
- Move the map insertion into a new `addTxsBeingValidated`, mirroring the verifier manager, so the
  key is computed in one place.
- Key `validatorCommitter.txBeingValidated` by `servicepb.Height` rather than `TxRef.TxId`, again
  mirroring the verifier manager. The height is the transaction's own identity within the block, so
  matching a status back to its node no longer depends on transaction IDs being unique among the
  transactions currently in flight.

#### Additional details (Optional)

The failed-forward re-add is currently reachable only while the manager itself is tearing down,
because both output writes are bound to the manager's context rather than the stream's. It is
guarded here so the invariant holds regardless of how those contexts are wired later.

`TestValidatorCommitterAddAndRecoverPendingTxs` covers the add/recover round trip that the guard
relies on.

#### Related issues

- resolves #608

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #710: [coordinator] Fix VC manager in-flight transaction tracking

Coverage Stats

7 of 9 new or added lines in 1 file covered. (77.78%)

20 existing lines in 8 files now uncovered.

10351 of 11328 relevant lines covered (91.38%)

34272.05 hits per line