hyperledger / fabric-x-committer

90%

main: 90%

LAST BUILD ON BRANCH optimize-map-block

branch: optimize-map-block

CHANGE BRANCH

x

Reset

• optimize-map-block
• apt-ci-fix
• bft-delivery
• ci-gotestsum
• commit-config-immediately
• config-docs-yaml
• connection-test-dep
• coveralls
• cryptogen-recreate-support
• default-test-node-startup-setup
• deliver-check-block-order
• deliver-seek-tls-cert
• doc-loadgen-artifacts
• dynamic-root-ca
• enable-pprof
• expose-ledger-api
• fabric-logging
• fix-connection-reset
• fix-container-image
• fix-container-test-macos
• fix-db-test
• fix-falky-svmupdate-test
• fix-flaky-conn-metrics
• fix-flaky-loadgen-coord
• fix-master-tserver-rf
• fix-port-container-test
• fix-release-path
• fix-sign
• fix-test-node-with-insecure
• fix-waiting-tx-count
• go-fix
• ledger-service-wait-behaviour
• lifecycle-policy
• limit-block-apis
• limit-inputs-block-apis
• loadgen-remove-ctx
• main
• make-fixes
• metrics-tls
• migrate-to-postgres-official-image
• minimize-logs
• mock-orderer-features
• mock-orderer-stream-holder
• namespace-policy-docs
• pgx5
• postgres-renaming
• qs-pen-test-fix
• rate-limit-sidecar
• root-ca-workaround-fix
• sidecar-block-store-code-fix
• sidecar-limit-active-txids-notifier
• sidecar-remove-chan-id
• split-tablets
• sustain-config
• sync-block
• template-tls-per-endpoint
• test-coverage-improve
• test-coverage-tests
• test-limiter-max-wait
• test-minor-fixes
• test-query-status
• test-tls-flatten
• testcrypto-refactor
• tls-docs-update
• update-to-latest-common
• update-to-yugabytedb-latest-lts
• upgrade-pg
• worktree-notification-docs

Build # 22951501048

Build Type

Pull #316

github

Committed by cendhu

Commit Message

Address review comments

To support the fuzz contract:
- extractField now returns the last match for duplicate fields, matching
  proto3's last-writer-wins semantics for scalar fields. Note that proto.Marshal
  would not add duplicate fields but proto.Unmarshal parses them correctly even
  if there are duplicate fields.
- Remove the "advance past field 1" optimization in ChannelHeader parsing
  since last-writer-wins requires searching from the beginning for each field.
  Example bytes (field order): field5, field1, field5, field1
  - Last field 1 is at position 4. Advancing past it means we only search positions 5+ for field 5.
  - But the last field 5 is at position 3 — we'd miss it.

Signed-off-by: Senthilnathan <cendhu@gmail.com>

fix all bugs

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Pull Request Pull Request #316: Introduce UnmarshalEnvelopeLite to speed up mapBlock

Run Details

122 of 151 new or added lines in 3 files covered. (80.79%)

25 existing lines in 5 files now uncovered.

9497 of 10604 relevant lines covered (89.56%)

1.33 hits per line