hyperledger / fabric-x-committer

91%

main: 91%

LAST BUILD ON BRANCH coordinator-vc-api-split

branch: coordinator-vc-api-split

CHANGE BRANCH

x

Reset

• coordinator-vc-api-split
• add-live-connection-monitoring
• additional-db-test
• admin-db-init
• apt-ci-fix
• auto-merge-fix
• backoff-v5
• bccsp-race
• bench-report-metrics
• bft-delivery
• bft-metrics
• bob-reduce-context
• bob-rules
• buffer-race
• build-unify
• channel-race
• ci-gotestsum
• cli-refactor
• cli-refs
• client-test-race
• client-tls-bug
• commit-config-immediately
• config-docs-yaml
• configurable-coordinator-parameters
• configurable-retry-sig-vc-managers
• connection-test-dep
• coord-queue-deadlock
• coordinator-docs
• coordinator-manager-metrics
• coordinator-manager-parity
• coordinator-metadata-fix
• coordinator-test-no-db
• coveralls
• create-multiple-namespaces-test
• create-new-sys-ns
• cryptogen-recreate-support
• dedup-templ
• default-test-node-startup-setup
• default-viper
• deliver-check-block-order
• deliver-seek-tls-cert
• deliver-seek-tls-cert-fix
• deliverorderer-tests
• delivery-data-blocks
• dependabot/go_modules/go_modules-9c5197dcb8
• dependabot/go_modules/go_modules-d35c03d4db
• dependabot/go_modules/go_modules-dc1255629f
• dependabot/go_modules/go_modules-eee72e131a
• dependencygraph-race
• deployment-strategy
• doc-loadgen-artifacts
• docker-moby-update
• dynamic-root-ca
• dynamic-tls
• enable-pprof
• expose-ledger-api
• external-server-config
• extract-prometheus-startup-and-grpc-server-start
• fabric-lib-go-v1.1.3
• fabric-logging
• fix-automatic-env
• fix-bft-detection
• fix-connection-reset
• fix-container-image
• fix-container-test-macos
• fix-db-test
• fix-falky-svmupdate-test
• fix-flaky
• fix-flaky-conn-metrics
• fix-flaky-loadgen-coord
• fix-master-tserver-rf
• fix-metrics
• fix-mkdoc-url
• fix-port-container-test
• fix-release-path
• fix-sign
• fix-test-node-with-insecure
• fix-test-wait
• fix-waiting-tx-count
• fix/690-notifier-metric-assertions
• fix/696-integration-port-reservation
• fix/712-grpcretry-port-reservation
• fix/coordinator-waiting-status-count
• fix/todo-001
• fix/todo-002
• fix/todo-005
• fix/todo-017
• flaky-coordinator-test-615
• flaky-test-orderer
• getpeersmspdirs-no-hardcode
• go-fix
• grpc-logger-fix
• grpcservice-refactor
• healthz-check
• http-endpoint
• inline-commands
• iss-640
• keep-alive-parameters-testing
• ledger-service-wait-behaviour
• lifecycle-policy
• limit-block-apis
• limit-inputs-block-apis
• llm-adjust
• load-config-block-certs
• loadgen-config-cleanup
• loadgen-const-distribution-shorthand
• loadgen-index-addressable-keys
• loadgen-manual-msp
• loadgen-probability-validation
• loadgen-remove-ctx
• loadgen-remove-query
• main
• make-ci-local
• make-fixes
• makefile-lints
• makefile-test-flags
• metrics-bob-rules
• metrics-tls
• metrics-url-race
• migrate-to-postgres-official-image
• minimize-logs
• mkdocs
• mock-orderer-direct-config
• mock-orderer-dynamic-tls
• mock-orderer-features
• mock-orderer-stream-holder
• mock-verifier-race
• move-retry-package
• move-testcrypto-to-common
• namespace-policy-docs
• notifier-metrics
• notify-full-block
• notify-tx-metadata
• optimize-map-block
• orderer-config-race
• pgx5
• postgres-renaming
• prom-refactor
• publish-common-packages
• qs-pen-test-fix
• race-detection
• rate-limit-sidecar
• refactor-channel
• refactor-cmd
• refactor-test
• release-1.0
• remove-common-root-cas
• remove-file
• remove-ifrit-gomega
• remove-loadgen-distribution
• remove-non-maintained-pkg
• rename
• rename-materials
• rename-util-files
• retry-infinite-max-elapsed-time
• review-ai-prompt
• rm-gpl-tools
• rm-reployment
• rm-unused
• root-ca-workaround-fix
• service-manager
• sidecar-block-store-code-fix
• sidecar-diagram-mod
• sidecar-diagrm
• sidecar-limit-active-txids-notifier
• sidecar-process-snapshot-checkpoint
• sidecar-race
• sidecar-receiver-unwrap-envelope-lite
• sidecar-remove-chan-id
• sidecar-unified
• skill-commit
• skill-dev
• skills-fork-pr-workflow
• skills-omit-verification-from-pr-body
• snapshot-creation
• snapshot-hash
• snapshot-reject-if-inprogress
• split-tablets
• start-server-readiness-context
• sustain-config
• sync-block
• template-tls-per-endpoint
• test-container-port-binding
• test-coverage-connection
• test-coverage-improve
• test-coverage-latency
• test-coverage-tests
• test-limiter-max-wait
• test-minor-fixes
• test-query-status
• test-tls-flatten
• testcrypto-race
• testcrypto-refactor
• tls-docs-update
• tx-metadata
• unused-code
• update-common
• update-common-dep
• update-dep
• update-dep-4
• update-depenencies-3
• update-deps
• update-dev-skills
• update-to-latest-common
• update-to-yugabytedb-latest-lts
• upgrade-common-dep
• upgrade-pg
• utils-channel-optional-writer
• vc-docs
• vc-manager-tracker-key
• vc-race
• vc-resource-leak
• verifier-snapshot-checkpoint
• verifier-test-remove-gomega
• verifier-timeout
• viper-default-annot
• worktree-notification-docs

Build # 30359199169

Build Type

Pull #713

github

Committed by liran-funaro

Commit Message

[coordinator] Split the VC request/response API from the VC manager

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Move the load-balanced vcservice connection, and the request/response calls it serves
  (`SetLastCommittedBlockNumber`, `GetNextBlockNumberToCommit`, `GetTransactionsStatus`,
  `GetNamespacePolicies`, `GetConfigTransaction`), out of `validatorCommitterManager` and into a new
  `validatorCommitterAPI`. These calls are served by whichever vcservice the load-balanced
  connection picks and are issued outside the transaction pipeline, so the manager is now
  responsible only for streaming transactions to the vcservices.
- The coordinator owns the API and creates it in `Run` before starting the managers. The
  `channel.Ready` handshake that existed only to tell the coordinator when the manager had assigned
  its `commonClient` is therefore removed, along with the `WaitForReady` call in `Run`.
- `newVcMgrTestEnv` waits for the vcservice connections instead of that handshake, matching what
  `newSvMgrTestEnv` already does for the verifiers.

#### Related issues

- resolves partly #611

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #713: [coordinator] Split the VC request/response API from the VC manager

Coverage Stats

54 of 67 new or added lines in 2 files covered. (80.6%)

6 existing lines in 4 files now uncovered.

10347 of 11332 relevant lines covered (91.31%)

34876.67 hits per line