elixir-mint / mint

91%

main: 91%

LAST BUILD ON BRANCH http2-followups

branch: http2-followups

CHANGE BRANCH

x

Reset

Sync Branches

• http2-followups
• al/1.18
• al/bump-ci
• al/ci
• al/client-settings
• al/deps
• al/elixir-1.10
• al/elixir-1.11+
• al/fix-leak
• al/fix-tests
• al/http2-logs
• al/improve-defguard
• al/modernize-ci
• al/stream-docs
• al/update-ci-versions
• al/updates
• allow-not-validating-target
• allow_302_for_twitter_integration_test
• andrea/code-coverage
• andrea/dialyzer
• andrea/fix-guard
• andrea/new-ci-versions
• apply-http2-client-settings
• check-http2-content-length
• chore/replace-deprecated-xref-exclude
• clamp-tunnel-timeout
• close_sockets_on_error
• comp-time-optimization
• configurable-test-ports
• connect-tunnel-fixes
• connection-docs-ref
• contributing-and-testing-housekeeping
• dialyzer-without-ignore-file
• docs-for-open
• dont-close-socket-on-recv-timeout
• ericmj/deprecate-read-write
• ericmj/fix-1xx-informational-response
• ericmj/http2-connection-window-size
• ericmj/http2-larger-default-windows
• ericmj/inet4-option
• ericmj/local-h2c-integration-tests
• ericmj/support-elixir-1.12
• ericmj/update-ubuntu
• fix-cannot-build-docker-image-using-podman-compose
• fix-dialyzer
• fix-http1-tests-not-tagged-correctly
• fix-incorrect-ci-badge
• fix-warnings
• fix/446-proxy-host-header
• fix/http10-connect-tunnel
• fix/humize_error_code_custom_error
• forward-proxy-mode
• http-fuzz-properties
• http1-followups
• http1-header-parsing
• http1-line-size-limit
• http1-pipelining
• http1-reason-phrase
• http2-connect-target
• http2-frame-validation
• http2-response-semantics
• http2-server-push
• https-tunnel-proxies
• ignore-http2-window-update-on-closed-streams
• ip-address-match-fun
• ipv6-host-header
• jv-default-store
• jv-elixir-1-19
• keep-http1-state-after-pipelined-responses
• main
• next_body_chunk
• np/export-error-types
• optimize-http/2-request-creation
• patch-3
• preserve_header_case
• pvthuyen/add-support-for-cacerts-get
• refs/heads/main
• refs/pull/399/merge
• refs/pull/407/merge
• refs/pull/500/merge
• return-responses-in-parse-order
• rewrite-contributing-and-testing-doc
• run-ci-against-erlang-27.1
• stream-http1-headers
• test-followups
• tunnel-target-identity
• unnecessary-rst-stream-2
• unsafe-proxy-opts
• update-deps
• use-hpax-protocol-resize
• use_local_http_bin_in_all_tests
• v1.10
• validate-http2-response-headers
• whatyouhide/issue311
• wm-decompression
• wm-docker-compose
• wm-recv-response
• wrap-tunnel-errors

Build # f707415a1199ec76812b001925841af938bb7478-PR-522

Build Type

Pull #522

github

Committed by ericmj

Commit Message

Treat a 204 response to CONNECT as an established tunnel

The check for 204 and 304 responses, which must not have content, came
before the check for 2xx responses to CONNECT. A CONNECT request
answered with 204 was treated as a response without content, so the
first DATA frame on the tunnel failed the request with a protocol error.

RFC 9110 9.3.6 and RFC 9113 8.5 make any 2xx response to CONNECT
establish a tunnel, so the CONNECT case is checked first and DATA
frames after a 204 are delivered as tunnel data.

Pull Request Pull Request #522: Fix HTTP/2 header block bound, push validation and CONNECT 204

Coverage Stats

52 of 54 new or added lines in 1 file covered. (96.3%)

2 existing lines in 1 file now uncovered.

1827 of 2012 relevant lines covered (90.81%)

717.04 hits per line