elixir-mint / mint

88%

main: 88%

LAST BUILD ON BRANCH unsafe-proxy-opts

branch: unsafe-proxy-opts

CHANGE BRANCH

x

Reset

Sync Branches

• unsafe-proxy-opts
• al/1.18
• al/bump-ci
• al/ci
• al/client-settings
• al/deps
• al/elixir-1.10
• al/elixir-1.11+
• al/fix-leak
• al/fix-tests
• al/http2-logs
• al/improve-defguard
• al/modernize-ci
• al/stream-docs
• al/update-ci-versions
• al/updates
• allow-not-validating-target
• allow_302_for_twitter_integration_test
• andrea/code-coverage
• andrea/dialyzer
• andrea/fix-guard
• andrea/new-ci-versions
• chore/replace-deprecated-xref-exclude
• clamp-tunnel-timeout
• comp-time-optimization
• configurable-test-ports
• connect-tunnel-fixes
• connection-docs-ref
• contributing-and-testing-housekeeping
• docs-for-open
• dont-close-socket-on-recv-timeout
• ericmj/deprecate-read-write
• ericmj/fix-1xx-informational-response
• ericmj/http2-connection-window-size
• ericmj/http2-larger-default-windows
• ericmj/inet4-option
• ericmj/local-h2c-integration-tests
• ericmj/support-elixir-1.12
• ericmj/update-ubuntu
• fix-cannot-build-docker-image-using-podman-compose
• fix-dialyzer
• fix-http1-tests-not-tagged-correctly
• fix-incorrect-ci-badge
• fix-warnings
• fix/446-proxy-host-header
• fix/humize_error_code_custom_error
• http1-reason-phrase
• http2-connect-target
• https-tunnel-proxies
• ip-address-match-fun
• jv-default-store
• jv-elixir-1-19
• main
• next_body_chunk
• np/export-error-types
• optimize-http/2-request-creation
• patch-3
• preserve_header_case
• pvthuyen/add-support-for-cacerts-get
• refs/heads/main
• refs/pull/399/merge
• refs/pull/407/merge
• rewrite-contributing-and-testing-doc
• run-ci-against-erlang-27.1
• tunnel-target-identity
• unnecessary-rst-stream-2
• update-deps
• use_local_http_bin_in_all_tests
• whatyouhide/issue311
• wm-decompression
• wm-docker-compose
• wm-recv-response
• wrap-tunnel-errors

Build # e26824eafcb7e61434cb5454341c896b32169a3e-PR-494

Build Type

Pull #494

github

Committed by ericmj

Commit Message

Don't leak target options into the proxy connection in forward-proxy mode

Mint.HTTP.connect/4 merged the target connect options with the proxy
options and handed the whole set to the connection to the proxy. A
target :hostname was therefore used as the proxy connection's hostname,
so with an :https proxy the proxy's certificate was verified against
the target's identity, and :transport_opts meant for the target applied
to the proxy socket.

Forward-proxy mode now keeps the two option sets separate, like tunnel
mode already does: the proxy connection is configured by the options in
the :proxy tuple, while the options given to Mint.HTTP.connect/4
describe the target (its :hostname identity and the :proxy_headers).

Pull Request Pull Request #494: Don't leak target options into the proxy connection in forward-proxy mode

Coverage Stats

1434 of 1637 relevant lines covered (87.6%)

492.55 hits per line