elixir-mint / mint

91%

main: 91%

LAST BUILD ON BRANCH http1-followups

branch: http1-followups

CHANGE BRANCH

x

Reset

Sync Branches

• http1-followups
• al/1.18
• al/bump-ci
• al/ci
• al/client-settings
• al/deps
• al/elixir-1.10
• al/elixir-1.11+
• al/fix-leak
• al/fix-tests
• al/http2-logs
• al/improve-defguard
• al/modernize-ci
• al/stream-docs
• al/update-ci-versions
• al/updates
• allow-not-validating-target
• allow_302_for_twitter_integration_test
• andrea/code-coverage
• andrea/dialyzer
• andrea/fix-guard
• andrea/new-ci-versions
• apply-http2-client-settings
• check-http2-content-length
• chore/replace-deprecated-xref-exclude
• clamp-tunnel-timeout
• close_sockets_on_error
• comp-time-optimization
• configurable-test-ports
• connect-tunnel-fixes
• connection-docs-ref
• contributing-and-testing-housekeeping
• dialyzer-without-ignore-file
• docs-for-open
• dont-close-socket-on-recv-timeout
• ericmj/deprecate-read-write
• ericmj/fix-1xx-informational-response
• ericmj/http2-connection-window-size
• ericmj/http2-larger-default-windows
• ericmj/inet4-option
• ericmj/local-h2c-integration-tests
• ericmj/support-elixir-1.12
• ericmj/update-ubuntu
• fix-cannot-build-docker-image-using-podman-compose
• fix-dialyzer
• fix-http1-tests-not-tagged-correctly
• fix-incorrect-ci-badge
• fix-warnings
• fix/446-proxy-host-header
• fix/http10-connect-tunnel
• fix/humize_error_code_custom_error
• forward-proxy-mode
• http-fuzz-properties
• http1-header-parsing
• http1-line-size-limit
• http1-pipelining
• http1-reason-phrase
• http2-connect-target
• http2-followups
• http2-frame-validation
• http2-response-semantics
• http2-server-push
• https-tunnel-proxies
• ignore-http2-window-update-on-closed-streams
• ip-address-match-fun
• ipv6-host-header
• jv-default-store
• jv-elixir-1-19
• keep-http1-state-after-pipelined-responses
• main
• next_body_chunk
• np/export-error-types
• optimize-http/2-request-creation
• patch-3
• preserve_header_case
• pvthuyen/add-support-for-cacerts-get
• refs/heads/main
• refs/pull/399/merge
• refs/pull/407/merge
• refs/pull/500/merge
• return-responses-in-parse-order
• rewrite-contributing-and-testing-doc
• run-ci-against-erlang-27.1
• stream-http1-headers
• test-followups
• tunnel-target-identity
• unnecessary-rst-stream-2
• unsafe-proxy-opts
• update-deps
• use-hpax-protocol-resize
• use_local_http_bin_in_all_tests
• v1.10
• validate-http2-response-headers
• whatyouhide/issue311
• wm-decompression
• wm-docker-compose
• wm-recv-response
• wrap-tunnel-errors

Build # defd0a8c5ab9efdecd637dfafca94338a135d505-PR-521

Build Type

Pull #521

github

Committed by ericmj

Commit Message

Fail requests pipelined behind a 101 response

After a 101 response the connection stayed open with the queued
requests in place, so bytes arriving later, which belong to the protocol
the server switched to (RFC 9110 15.2.2), were parsed as HTTP/1
responses to those requests.

Queued requests now fail with the new :connection_upgraded error when
the 101 response completes. Bytes arriving later are unexpected data as
long as no new request is made on the connection. A failed request that
was streaming its body can't stream the rest of it. :unprocessed isn't
used because the pipelined request bytes reached the server as part of
the new protocol, so the request might have been processed. The bytes
after the 101 response in the same packet are still delivered as data
for the upgrade request.

Pull Request Pull Request #521: Fix HTTP/1 Transfer-Encoding, 1xx close and upgrade handling

Coverage Stats

50 of 51 new or added lines in 2 files covered. (98.04%)

5 existing lines in 3 files now uncovered.

1820 of 2010 relevant lines covered (90.55%)

707.11 hits per line