elixir-mint / mint

88%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• al/1.18
• al/bump-ci
• al/ci
• al/client-settings
• al/deps
• al/elixir-1.10
• al/elixir-1.11+
• al/fix-leak
• al/fix-tests
• al/http2-logs
• al/improve-defguard
• al/modernize-ci
• al/stream-docs
• al/update-ci-versions
• al/updates
• allow-not-validating-target
• allow_302_for_twitter_integration_test
• andrea/code-coverage
• andrea/dialyzer
• andrea/fix-guard
• andrea/new-ci-versions
• chore/replace-deprecated-xref-exclude
• clamp-tunnel-timeout
• close_sockets_on_error
• comp-time-optimization
• configurable-test-ports
• connect-tunnel-fixes
• connection-docs-ref
• contributing-and-testing-housekeeping
• docs-for-open
• dont-close-socket-on-recv-timeout
• ericmj/deprecate-read-write
• ericmj/fix-1xx-informational-response
• ericmj/http2-connection-window-size
• ericmj/http2-larger-default-windows
• ericmj/inet4-option
• ericmj/local-h2c-integration-tests
• ericmj/support-elixir-1.12
• ericmj/update-ubuntu
• fix-cannot-build-docker-image-using-podman-compose
• fix-dialyzer
• fix-http1-tests-not-tagged-correctly
• fix-incorrect-ci-badge
• fix-warnings
• fix/446-proxy-host-header
• fix/http10-connect-tunnel
• fix/humize_error_code_custom_error
• http1-reason-phrase
• http2-connect-target
• https-tunnel-proxies
• ip-address-match-fun
• jv-default-store
• jv-elixir-1-19
• main
• next_body_chunk
• np/export-error-types
• optimize-http/2-request-creation
• patch-3
• preserve_header_case
• pvthuyen/add-support-for-cacerts-get
• refs/heads/main
• refs/pull/399/merge
• refs/pull/407/merge
• refs/pull/500/merge
• rewrite-contributing-and-testing-doc
• run-ci-against-erlang-27.1
• stream-http1-headers
• tunnel-target-identity
• unnecessary-rst-stream-2
• unsafe-proxy-opts
• update-deps
• use_local_http_bin_in_all_tests
• whatyouhide/issue311
• wm-decompression
• wm-docker-compose
• wm-recv-response
• wrap-tunnel-errors

Build # bfc6454f92ade5bb7afeede28b3f741378fc985c

Build Type

push

github

Committed by web-flow

Commit Message

Close TCP sockets on errors in HTTP/1 (#502)

In some cases, when handling a failure, Mint would only set the conn
state to :closed but would not close the underlying socket. These
sockets stay open until the calling process that owns them exits, and
may therefore accumulate until resources are exhausted.

Every relevant %{conn | state: :closed} inside Mint.HTTP1 is replaced
with internal_close that in addition to setting the state also closes
the socket.

Tests that asserted closed conn now also assert that the socket is
closed. New tests that demonstrate the problem are added. They would
fail without the fix and they pass with the fix in place.

Fixes #501.

Coverage Stats

6 of 8 new or added lines in 1 file covered. (75.0%)

1502 of 1700 relevant lines covered (88.35%)

517.46 hits per line