elixir-mint / mint

89%

main: 91%

LAST BUILD ON BRANCH apply-http2-client-settings

branch: apply-http2-client-settings

CHANGE BRANCH

x

Reset

Sync Branches

• apply-http2-client-settings
• al/1.18
• al/bump-ci
• al/ci
• al/client-settings
• al/deps
• al/elixir-1.10
• al/elixir-1.11+
• al/fix-leak
• al/fix-tests
• al/http2-logs
• al/improve-defguard
• al/modernize-ci
• al/stream-docs
• al/update-ci-versions
• al/updates
• allow-not-validating-target
• allow_302_for_twitter_integration_test
• andrea/code-coverage
• andrea/dialyzer
• andrea/fix-guard
• andrea/new-ci-versions
• check-http2-content-length
• chore/replace-deprecated-xref-exclude
• clamp-tunnel-timeout
• close_sockets_on_error
• comp-time-optimization
• configurable-test-ports
• connect-tunnel-fixes
• connection-docs-ref
• contributing-and-testing-housekeeping
• dialyzer-without-ignore-file
• docs-for-open
• dont-close-socket-on-recv-timeout
• ericmj/deprecate-read-write
• ericmj/fix-1xx-informational-response
• ericmj/http2-connection-window-size
• ericmj/http2-larger-default-windows
• ericmj/inet4-option
• ericmj/local-h2c-integration-tests
• ericmj/support-elixir-1.12
• ericmj/update-ubuntu
• fix-cannot-build-docker-image-using-podman-compose
• fix-dialyzer
• fix-http1-tests-not-tagged-correctly
• fix-incorrect-ci-badge
• fix-warnings
• fix/446-proxy-host-header
• fix/http10-connect-tunnel
• fix/humize_error_code_custom_error
• forward-proxy-mode
• http-fuzz-properties
• http1-followups
• http1-header-parsing
• http1-line-size-limit
• http1-pipelining
• http1-reason-phrase
• http2-connect-target
• http2-followups
• http2-frame-validation
• http2-response-semantics
• http2-server-push
• https-tunnel-proxies
• ignore-http2-window-update-on-closed-streams
• ip-address-match-fun
• ipv6-host-header
• jv-default-store
• jv-elixir-1-19
• keep-http1-state-after-pipelined-responses
• main
• next_body_chunk
• np/export-error-types
• optimize-http/2-request-creation
• patch-3
• preserve_header_case
• pvthuyen/add-support-for-cacerts-get
• refs/heads/main
• refs/pull/399/merge
• refs/pull/407/merge
• refs/pull/500/merge
• return-responses-in-parse-order
• rewrite-contributing-and-testing-doc
• run-ci-against-erlang-27.1
• stream-http1-headers
• test-followups
• tunnel-target-identity
• unnecessary-rst-stream-2
• unsafe-proxy-opts
• update-deps
• use-hpax-protocol-resize
• use_local_http_bin_in_all_tests
• v1.10
• validate-http2-response-headers
• whatyouhide/issue311
• wm-decompression
• wm-docker-compose
• wm-recv-response
• wrap-tunnel-errors

Build # 48a00663c2781bb26d8fb09971e23d616df873d9-PR-507

Build Type

Pull #507

github

Committed by ericmj

Commit Message

Keep the HTTP/2 receive window credit in sync when the window shrinks

Shrinking :initial_window_size adjusted each stream's receive window
size but not its remaining credit. The server applies the difference to
its view of the window as well (RFC 9113 6.9.2), so the next refill
computed an increment of zero or a negative number and sent it in a
WINDOW_UPDATE frame. A negative increment lands in the unsigned 31-bit
field as a value near 2^31, which the server has to answer with a
FLOW_CONTROL_ERROR stream reset (RFC 9113 6.9.1), and a zero increment
is a PROTOCOL_ERROR stream error (RFC 9113 6.9).

The remaining credit now follows the size change, and a refill is only
sent when the increment is positive.

Pull Request Pull Request #507: Keep the HTTP/2 receive window credit in sync when the window shrinks

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

1544 of 1742 relevant lines covered (88.63%)

555.3 hits per line